Bug 958038
| Summary: | rpmlint doesn't handle Unicode encoding errors gracefully | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Alicja Kario <hkario> | ||||||||
| Component: | rpmlint | Assignee: | Thomas Woerner <twoerner> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Alicja Kario <hkario> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 6.4 | CC: | abienven, ksrot | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | rpmlint-0.94-3.1.el6 | Doc Type: | Bug Fix | ||||||||
| Doc Text: |
When a package had a UTF-8 encoding error in the description, or the description was encoded in a different character set, then rpmlint terminated unexpectedly with a segmentation fault. With this update, rmplint returns an error message that the description has incorrectly encoded UTF-8 data (tag-not-utf8 error), and crashes no longer occur in the described scenario.
|
Story Points: | --- | ||||||||
| Clone Of: | |||||||||||
| : | 971787 (view as bug list) | Environment: | |||||||||
| Last Closed: | 2013-06-17 07:33:38 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 971787 | ||||||||||
| Attachments: |
|
||||||||||
the 'rpmlint' command must be run in non unicode enabled environment:
export LC_ALL=POSIX
export LANG=POSIX
TTY="`/usr/bin/tty`"
# stop unicode
kbd_mode -a
if test -t ; then
printf '\033%%@'
fi
stty -iutf8
uid="`id -u 2>/dev/null`" ||:
if [ "$uid" = '0' ]; then
[ ! -r "$HOME/.kbd/.keymap_sv" ] ||
loadkeys "$HOME/.kbd/.keymap_sv"
fi
in regular interactive shell from Fedora/RHEL it won't crash
Created attachment 757918 [details]
Proposed patch
This patch fixes the symptom.
The origin of the problem is that unicode is deactivated in the test envirnoment.
Created attachment 758063 [details]
spec file that doesn't cause the crash in rpmlint
Created attachment 758065 [details]
spec file that does cause crash in rpmlint
when rpmlint is run in non unicode enabled terminal, this spec file causes it to crash
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0948.html |
Description of problem: When a package has a UTF-8 encoding error in description (or description encoded in some other charset) rpmlint crashes. Version-Release number of selected component (if applicable): rpmlint-0.94-2.el6.noarch How reproducible: Always Steps to Reproduce: 1. Create a spec file having characters from other charset in description (e.g. using "echo Łódź | iconv -f utf8 -t cp1250 >> package.spec") 2. Build a package using rpmbuild -ba 3. run "rpmlint -i package.rpm" Actual results: rpmlint-test-tag-not-utf8.noarch: W: spelling-error %description -l en_US utf -> fut, Ute, Utah The value of this tag appears to be misspelled. Please double-check. 0 packages and 0 specfiles checked; 0 errors, 2 warnings. Traceback (most recent call last): File "/usr/share/rpmlint/rpmlint.py", line 352, in <module> main() File "/usr/share/rpmlint/rpmlint.py", line 158, in main runChecks(pkg) File "/usr/share/rpmlint/rpmlint.py", line 218, in runChecks check.check(pkg) File "/usr/share/rpmlint/TagsCheck.py", line 650, in check self.check_description(pkg, lang, ignored_words) File "/usr/share/rpmlint/TagsCheck.py", line 805, in check_description spell_check(pkg, utf8desc, '%%description -l %s', lang, ignored_words) File "/usr/share/rpmlint/TagsCheck.py", line 473, in spell_check printWarning(pkg, 'spelling-error', fmt % lang, err.word, sug) File "/usr/share/rpmlint/Filter.py", line 28, in printWarning _print("W", pkg, reason, details) File "/usr/share/rpmlint/Filter.py", line 63, in _print print (s) UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 74: ordinal not in range(128) Expected results: Error message that the description has wrongly encoded utf-8 data (tag-not-utf8 error) Additional info: