Bug 958094

Summary:	Review Request: movgrab - An online video downloader in console
Product:	[Fedora] Fedora	Reporter:	Christopher Meng <i>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED CANTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mario.blaettermann, misc, notting, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-26 10:45:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christopher Meng 2013-04-30 11:34:19 UTC

Spec URL: http://cicku.me/movgrab.spec
SRPM URL: http://cicku.me/movgrab-1.2.1-1.fc20.src.rpm

Description: movgrab is a downloader for all those pesky sites that insist you use a big 
fat browser that runs flash in order to see their content.

Features:
Command-line application.
No dependancies.
HTTP Proxy server support.
Write download to std-out to feed into another application.
Progress display while downloading.
Fork into background.

Fedora Account System Username: cicku

Comment 1 Christopher Meng 2013-04-30 11:39:28 UTC

Koji success:

http://koji.fedoraproject.org/koji/taskinfo?taskID=5317195

Comment 2 Mario Blättermann 2013-06-22 11:16:52 UTC

$ licensecheck -r *
libUseful-2.0/sha1.c: GPL (v2 or later)
libUseful-2.0/sha1.h: GPL (v2 or later)
libUseful-2.0/sha2.c: BSD (2 clause)
main.c: GPL (v3 or later)

(files with unknown licenses filtered out)

The license tag has to be "GPLv3+ and BSD".


The tarball bundles a library named libuseful, which is not available from Fedora yet, but there's a location where it is developed separately:
https://github.com/breckinloggins/libuseful
Would be better to package this first and make sure that movgrab uses that instead of the bundled one.

Moreover, there's another bundled library in libuseful itself. The files sha.* come from sha2 which is already in Fedora. The feature "No dependencies" says it actually, all you need is bundled with the tarball, which breaks one of the most fundamental Fedora rules.

Comment 3 Mario Blättermann 2013-06-22 11:23:36 UTC

(In reply to Mario Blättermann from comment #2)
> $ licensecheck -r *
> libUseful-2.0/sha1.c: GPL (v2 or later)
> libUseful-2.0/sha1.h: GPL (v2 or later)
> libUseful-2.0/sha2.c: BSD (2 clause)
> main.c: GPL (v3 or later)
> 
> (files with unknown licenses filtered out)
> 
> The license tag has to be "GPLv3+ and BSD".

Forget about the BSD license. Tha appropriate files are part of the bundled library, so you get "GPLv3+" only.