Bug 958169

Summary: Modified alert definition is not saved on confirming the save message after clicking on 'Back to List' button
Product: [JBoss] JBoss Operations Network Reporter: Sunil Kondkar <skondkar>
Component: UIAssignee: Jirka Kremser <jkremser>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: unspecified    
Version: JON 3.2CC: jkremser
Target Milestone: ER04   
Target Release: JON 3.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-02 20:34:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Sunil Kondkar 2013-04-30 14:06:13 UTC
Description of problem:

If an alert definition is modified and before saving the changes, if 'Back to List' button is clicked, it displays a pop up with confirmation message. Clicking on 'Yes' button on the pop up does not save the modification done in the alert definition.

Version-Release number of selected component (if applicable):

JBoss ON Version: 3.2.0.ALPHA_QA
Build Number: 7956b7c:fb4bbf8

Java version "1.6.0_18"
Database: PostgreSQL 9.1.0
Browser Version: Firefox 10.0.2

How reproducible:

Always

Steps to Reproduce:

1. Navigate to 'Alerts->Definitions tab of a resource having an existing alert definition
2. Click on the alert definition
3. Click on Edit button
4. Modify the alert definition ( Ex: Change the Priority or condition )
5. Do not save the alert definition and click on the 'Back to List' button.
6. It displays a confirmation message for saving the alert definition with Yes and No buttons
7. Click on Yes button.
8. Navigate again to the alert definition and check if the changes to the alert definition are saved
  
Actual results:

Modification to the alert definition are not saved.

Expected results:

The alert definition should be saved with the modifications.

Additional info:

Before saving the alert definition modifications, if user clicks anywhere else like history subtab, (except 'Back to List' button on the screen ) and clicks on Yes button on confirmation message, the changes are saved successfully.

Comment 1 Jirka Kremser 2013-05-17 11:01:28 UTC
branch:  master
link:    https://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=9a040dd8
time:    2013-05-17 12:41:31 +0200
commit:  9a040dd824209eb9e71bb22c7cf7d80a7c468485
author:  Jirka Kremser - jkremser
message: [BZ 958169] - Modified alert definition is not saved on confirming the
         save message after clicking on 'Back to List' button - Making
         the "Back to List" button disabled when editing the alert
         definition.

Comment 2 Jirka Kremser 2013-05-20 11:42:17 UTC
another two commits fixing the following use-case:
1) create a new alert definition
2) create a new alert condition withing the alert definition (created in 1)
3) save the alert definition
4) click to edit (alert definition)
5) modify the condition (created in 2)
6) save

the change wasn't correctly persisted, now it should be


branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=3ef61c186
time:    2013-05-20 13:36:45 +0200
commit:  3ef61c1860a590b16b461b81f85b0011b2ee620d
author:  Jirka Kremser - jkremser
message: [BZ 958169] - Modified alert definition is not saved on confirming the
         save message after clicking on 'Back to List' button - New
         method for creating an alert definitions was added to SLSB,
         because the UI requires the ids of newly created alert
         conditions.


branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=b638cc12a
time:    2013-05-20 13:29:43 +0200
commit:  b638cc12a5796b7ccb3789bf94768303b0ce0e3c
author:  Jirka Kremser - jkremser
message: [BZ 958169] - Modified alert definition is not saved on confirming the
         save message after clicking on 'Back to List' button - I18n
         (Instead of "Edit", now the button label says "Edit
         Condition").

Comment 3 Simeon Pinder 2013-07-02 20:33:38 UTC
This bz is available for testing with the latest 3.2.x brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=280316

Comment 4 Sunil Kondkar 2013-07-18 14:48:50 UTC
Verified on JON 3.2 Alpha 46 build. Build Number: dbe7020:45c43c4

Verified both the use cases. "Back to List" is button disabled when editing the alert definition and modified alert condition is saved successfully.

Comment 5 Sunil Kondkar 2013-09-27 12:14:02 UTC
Reopening the bug as this bug is reproducible in JBoss ON 3.2 ER1 build.

Version: 3.2.0.ER1
Build Number: 54dd29c:464a643

Steps to Reproduce:

1. Navigate to 'Alerts->Definitions tab of a resource having an existing alert definition
2. Click on the alert definition
3. Click on Edit button
4. Modify the alert definition ( Ex: Change the Priority or condition )
5. Do not save the alert definition and click on the 'Back to List' button.
6. It displays a confirmation message for saving the alert definition with Yes and No buttons
7. Click on Yes button.
8. Navigate again to the alert definition and check if the changes to the alert definition are saved

Actual result:

Modification to the alert definition are not saved.
The 'Back to List' button is enabled when editing the alert condition.

Expected results:

The alert definition should be saved with the modifications.
The 'Back to List' button should be disabled when editing the alert condition.

Comment 6 Jirka Kremser 2013-10-01 16:56:51 UTC
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=ad3703f5f
time:    2013-10-01 18:55:42 +0200
commit:  ad3703f5f88f547d397dc3612647970c8621b238
author:  Jirka Kremser - jkremser
message: [BZ 958169] - Modified alert definition is not saved on confirming the
         save message after clicking on 'Back to List' button -
         overriding the behavior of destroy method of the enhanced
         layout, because this class needs to get the data from child
         components before the destroy() is called. This was causing
         various JavaScript exceptions.

Comment 7 Simeon Pinder 2013-10-24 04:10:05 UTC
Moving to ON_QA for testing in the next build.

Comment 8 Sunil Kondkar 2013-10-25 15:01:33 UTC
Verified on Version: 3.2.0.ER4 Build Number: e413566:057b211

Modified alert definition are saved on confirming the save message after clicking on 'Back to List' button.