Bug 958981

Summary: [hotfix] Add EAP base/home directory bundle target to EAP 6 plug-in
Product: [JBoss] JBoss Operations Network Reporter: Larry O'Leary <loleary>
Component: Plugin -- JBoss EAP 6Assignee: Larry O'Leary <loleary>
Status: CLOSED ERRATA QA Contact: Larry O'Leary <loleary>
Severity: high Docs Contact:
Priority: urgent    
Version: JON 3.1.2CC: mazz
Target Milestone: ---Keywords: FutureFeature
Target Release: JON 3.1.2   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 958980 Environment:
Last Closed: 2013-05-23 14:21:33 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 958980    
Bug Blocks: 952331, 952333, 958984    

Description Larry O'Leary 2013-05-02 20:46:26 UTC
Back-port this feature/request into a hotfix patch for 3.1.2.

+++ This bug was initially created as a clone of JBoss ON 3.1.x Bug #958980 +++

+++ This bug was initially created as a clone of JBoss ON 3.2 Bug #957288 +++

+++ This bug was initially created as a clone of Bug #957282 +++

had discussions with larry l, charles c and alan s.

came to the conclusion we should support the same bundle target that the other jboss plugins support - being able to deploy anywhere under the base install dir of the AS installation.

--- Additional comment from John Mazzitelli on 2013-04-26 16:22:40 EDT ---

we want to add something like this:

      <bundle-target>
         <destination-base-dir name="Install Directory" description="The top directory where the application server is installed.">
            <value-context>pluginConfiguration</value-context>
            <value-name>homeDir</value-name>
         </destination-base-dir>
      </bundle-target>

We can keep the original destination-base-dir in here if we want (keeping the metric "deploy dir" target) and add any others we want in the future.

--- Additional comment from John Mazzitelli on 2013-04-29 11:16:08 EDT ---

git commit to master: fabce76

Comment 1 Larry O'Leary 2013-05-09 23:53:01 UTC
Committed to hotfix/jon3.1.2 as https://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=6f54aa596b809b75e0190b7a9fd9e033aaead1bb

commit 6f54aa596b809b75e0190b7a9fd9e033aaead1bb
Author: John Mazzitelli <mazz>
Date:   Mon Apr 29 11:15:34 2013 -0400

    BZ 957282 957288 add bundle target of "Install Directory"
    (cherry picked from commit fabce7666b08f73ea113807ec42b47a3d3eb5929)
    (cherry picked from commit a214605ec9abd53cc20b0a3eeeed34465b54e9f1)

Comment 3 Larry O'Leary 2013-05-16 00:02:19 UTC
Test failed.

The deployment does not end up in the standalone installation but instead is rooted at JBOSS_HOME. The expectation was to specify the deployment directory as the path prefix. For example:

    deployments/my-bundle-dest.war

Comment 4 Larry O'Leary 2013-05-16 18:43:16 UTC
Committed to hotfix/jon3.1.2 as https://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=55c4c4da4a23518c69f50e44b0c348946b74bf4c

commit 55c4c4da4a23518c69f50e44b0c348946b74bf4c
Author: John Mazzitelli <mazz>
Date:   Thu May 16 13:11:14 2013 -0400

    BZ 957282 957288 add bundle target of "Base Directory"
    (cherry picked from commit b9ce1ee3cc01fd2bf5614f10e164a1f4cebfe42c)
    (cherry picked from commit 79cf09367563622891b75d5f0f06f4b86d14a5d2)

Comment 6 Larry O'Leary 2013-05-16 22:25:14 UTC
Verified in EAP Plugin Pack Hotfix-03 for JBoss ON 3.1.2 build 32ec883:55c4c4d.

Tested Base Directory: deployments/MyTestBundle.war
Tested Install Directory: modules/org/rhq/MyEAPModuleBundle

Comment 7 Larry O'Leary 2013-05-23 14:21:33 UTC
Fixed and released in EAP Plugin Pack Hotfix-03 for JBoss ON 3.1.2.