Bug 959672
| Summary: | Review Request: libndp - Library for Neighbor Discovery Protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jiri Pirko <jpirko> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan, jiri, jpirko, notting, package-review, rkhan |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-24 09:07:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jiri Pirko
2013-05-04 17:11:43 UTC
formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
646ae93c4fc526b69fe2e0982e8cb801529cef9a libndp-20130504gitca3c399.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel subpackge
OK pkgconfig files in devel subpackage
OK no libtool .la droppings.
OK not a GUI app.
- rpmlint complains a bit
libndp-devel.x86_64: W: no-documentation
=> would be nice
libndp.src: W: spelling-error %description -l en_US ndptool -> toadstool
libndp.src: W: invalid-url Source0: libndp-20130504gitca3c399.tar.gz
=> can be ignored
This package is APPROVED.
New Package SCM Request ======================= Package Name: libndp Short Description: Library for Neighbor Discovery Protocol Owners: jirka Branches: f17 f18 f19 InitialCC: Git done (by process-git-requests). imported and built, closing |