Bug 959872
| Summary: | RFE: add INSTALL="install -p" to %make_install | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hans de Goede <hdegoede> |
| Component: | rpm | Assignee: | Packaging Maintenance Team <packaging-team-maint> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ffesti, i, jzeleny, novyjindrich, packaging-team-maint, pmatilai, rvokal |
| Target Milestone: | --- | Keywords: | Tracking |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-22 11:43:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Finally find this bug. https://fedoraproject.org/wiki/Make_install_packaging_draft I saw the draft and found that this. Indeed, per our guidelines, we should use -p option to install files. I wonder if we have hack the %configure but this solution is valid, too. Fixed upstream: https://github.com/rpm-software-management/rpm/commit/689d9a53dd787962ac9d9129008d9f6615a544f6 Fixed in rawhide/F27 now as of rpm >= 4.13.90. |
Hi, Currently pretty much every spec file needs to add INSTALL="install -p" to its %make_install invocation to keep time the original timestamps on things like images and man pages, can this be added to the %make_install macro please ? So change it to: %make_install %{__make} install DESTDIR=%{?buildroot} INSTALL="install -p" Regards, Hans