Bug 959965

Summary:	Implementation-Version missing from MANIFEST.MF in xml-resolver-1.2-redhat-3.jar
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Pavel Janousek <pjanouse>
Component:	Build	Assignee:	David Walluck <dwalluck>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Katerina Odabasi <kanovotn>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.2.0	CC:	dwalluck, fnasser, jdoyle, myarboro, pslavice, rsvoboda
Target Milestone:	ER3	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-15 16:22:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	927238

Description Pavel Janousek 2013-05-06 10:19:04 UTC

Description of problem:

List of artifact with missing Implementation-Version at all:
modules/system/layers/base/org/apache/xml-resolver/main/xml-resolver-1.2-redhat-3.jar

Additional info:

see https://bugzilla.redhat.com/show_bug.cgi?id=927238

Comment 1 Fernando Nasser 2013-05-06 15:39:43 UTC

David, can you investigate please how this may have happened?

Comment 2 David Walluck 2013-05-06 19:41:00 UTC

The manifest is being replaced at the end of the build thereby overwriting the original manifest which has the Implementation-Version.

The fix is to first set the property impl.version with ant so that it is set to the full redhat version, and then to patch the original manifest to combine with this with the other one so as to not overwrite the original.

Note that Bundle-Version: 1.2.0.v200806030312 does not match the Implementation-Version, but I am not worrying about this issue for this bug.

Comment 3 Fernando Nasser 2013-05-10 16:50:25 UTC

Too risky for this stage of 6.1.0

Comment 7 Fernando Nasser 2013-09-03 20:03:49 UTC

Hi David, how long would it take you to make this change?

Comment 8 David Walluck 2013-09-03 21:03:09 UTC

The work has been completed in the SCM, so I am estimating one to two more days for the build.

Comment 9 David Walluck 2013-09-14 07:11:01 UTC

The build has now been converted to MEAD (current version: 1.2.redhat-9). Therefore, the jar should now pick up the correct Implementation-Version information (from ${project.version}) just as any MEAD build would.

Comment 10 Pavel Jelinek 2013-09-30 12:22:43 UTC

Fixed for EAP 6.2.0 ER2. 
There is 'Implementation-Version: 1.2.redhat-9' in jboss-eap-6.2.0.ER2.zip/jboss-eap-6.2/modules/system/layers/base/org/apache/xml-resolver/main/xml-resolver-1.2.redhat-9.jar/META-INF/MANIFEST.MF