Bug 960010

Summary: FTBFS: self checks failure: FAIL: test_threads (test.test_gdb.PyBtTests)
Product: [Fedora] Fedora Reporter: Karsten Hopp <karsten>
Component: python3Assignee: Bohuslav "Slavek" Kabrda <bkabrda>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: 19CC: amcnabb, bkabrda, dmalcolm, dwa, tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: powerpc   
OS: Linux   
Whiteboard:
Fixed In Version: python3-3.3.1-4.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-14 04:49:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 920769    
Attachments:
Description Flags
build log with the find-more-information.patch
none
gdb output from test none

Description Karsten Hopp 2013-05-06 12:29:18 UTC
Description of problem:
FAIL: test_threads (test.test_gdb.PyBtTests)
Verify that "py-bt" indicates threads that are waiting for the GIL
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.3.1/Lib/test/test_gdb.py", line 760, in test_threads
    self.assertIn('Waiting for the GIL', gdb_output)
AssertionError: 'Waiting for the GIL' not found in 'Breakpoint 1 (builtin_id) pending.\n[Thread debugging using libthread_db enabled]\nUsing host libthread_db library "/lib64/libthread_db.so.1".\n[New Thread 0xfffb744f200 (LWP 45606)]\n[New Thread 0xfffb6a4f200 (LWP 45607)]\n[New Thread 0xfffb604f200 (LWP 45608)]\n[New Thread 0xfffaffff200 (LWP 45609)]\n\nBreakpoint 1, builtin_id (self=<module at remote 0xfffb77b9858>, v=42) at /builddir/build/BUILD/Python-3.3.1/Python/bltinmodule.c:966\n966\t{\n\nThread 5 (Thread 0xfffaffff200 (LWP 45609)):\nTraceback (most recent call first):\n  File "<string>", line 10, in run\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 639, in _bootstrap_inner\n    self.run()\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 616, in _bootstrap\n    self._bootstrap_inner()\n\nThread 4 (Thread 0xfffb604f200 (LWP 45608)):\nTraceback (most recent call first):\n  File "<string>", line 10, in run\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 639, in _bootstrap_inner\n    self.run()\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 616, in _bootstrap\n    self._bootstrap_inner()\n\nThread 3 (Thread 0xfffb6a4f200 (LWP 45607)):\nTraceback (most recent call first):\n  File "<string>", line 10, in run\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 639, in _bootstrap_inner\n    self.run()\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 616, in _bootstrap\n    self._bootstrap_inner()\n\nThread 2 (Thread 0xfffb744f200 (LWP 45606)):\nTraceback (most recent call first):\n  File "<string>", line 10, in run\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 639, in _bootstrap_inner\n    self.run()\n  File "/builddir/build/BUILD/Python-3.3.1/Lib/threading.py", line 616, in _bootstrap\n    self._bootstrap_inner()\n\nThread 1 (Thread 0xfffb7ff5f70 (LWP 45603)):\nTraceback (most recent call first):\n  File "<string>", line 18, in <module>\n'
----------------------------------------------------------------------
Ran 45 tests in 17.128s
FAILED (failures=1, skipped=15)

Version-Release number of selected component (if applicable):
python3-3.3.1-2.fc19

How reproducible:
always

Steps to Reproduce:
1.ppc-koji build --scratch f19 python3-3.3.1-2.fc19.src.rpm
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Karsten Hopp 2013-05-06 12:44:16 UTC
ppc32 builds just fine, ppc64 and ppc64p7 fail

Comment 2 Bohuslav "Slavek" Kabrda 2013-05-06 12:52:31 UTC
Seems that the issue is already reported upstream [1] with a candidate fix [2]. Could you please try applying the fix and see if that fixes the issue?

Thanks.

[1] http://bugs.python.org/issue17833
[2] http://bugs.python.org/file30007/possible-fix.patch

Comment 3 Karsten Hopp 2013-05-06 15:16:21 UTC
No, same problem:
http://ppc.koji.fedoraproject.org/kojifiles/work/tasks/9375/1089375/build.log

Patch 181 got applied and it still fails the same

Comment 4 Dave Malcolm 2013-05-06 15:22:18 UTC
Can you try also applying:
  http://bugs.python.org/file30005/find-more-information.patch
which will make the output of the failing test *much* more verbose, but should get useful info as to went wrong.

Comment 5 Karsten Hopp 2013-05-07 08:44:12 UTC
Created attachment 744605 [details]
build log with the find-more-information.patch

Comment 6 Dave Malcolm 2013-05-07 15:19:14 UTC
Created attachment 744785 [details]
gdb output from test

Thanks; I extracted the gdb output from the verbose log and am attaching

Comment 7 Dave Malcolm 2013-05-07 15:22:22 UTC
Thanks for the output.

Looks like
  http://bugs.python.org/file30007/possible-fix.patch
isn't good enough, for the reasons discussed in the upstream bug:
specifically, the threads waiting on the GIL were reported by gdb as in ".pthread_cond_timedwait" (note the leading dot character).
  
Can you try this patch instead:
  http://hg.python.org/cpython/rev/f4a6b731905a/
which is what I committed upstream.

Comment 8 David Aquilina 2013-05-07 21:20:13 UTC
*** Bug 960753 has been marked as a duplicate of this bug. ***

Comment 9 Dave Malcolm 2013-05-07 21:23:18 UTC
(In reply to comment #7)
> Thanks for the output.
> 
> Looks like
>   http://bugs.python.org/file30007/possible-fix.patch
> isn't good enough, for the reasons discussed in the upstream bug:
> specifically, the threads waiting on the GIL were reported by gdb as in
> ".pthread_cond_timedwait" (note the leading dot character).
>   
> Can you try this patch instead:
>   http://hg.python.org/cpython/rev/f4a6b731905a/
> which is what I committed upstream.

Direct link to raw version of that patch:
http://hg.python.org/cpython/raw-rev/f4a6b731905a

Comment 10 Karsten Hopp 2013-05-07 22:47:51 UTC
That last patch from comment 9 worked: 
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1092218

Would you mind doing a F19 build and file a bodhi update ? F20 most likely needs the same fix. Or I could add the path to git and do the builds, whatever you prefer....

Comment 11 Dave Malcolm 2013-05-09 16:14:28 UTC
Fix committed to "master" for f20 as:

http://pkgs.fedoraproject.org/cgit/python3.git/commit/?id=721c1efdac18333767c4d2aec7ab33cd44458183

Building python3-3.3.1-4.fc20 for rawhide
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5356134

Comment 12 Dave Malcolm 2013-05-09 16:22:10 UTC
Fix committed to "f19" as:
http://pkgs.fedoraproject.org/cgit/python3.git/commit/?h=f19&id=9d658b4031a765b4b2fc7a4cfde5337736019c42

Building python3-3.3.1-4.fc19 for f19-candidate
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5356168

Comment 13 Fedora Update System 2013-05-09 17:13:02 UTC
python3-3.3.1-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python3-3.3.1-4.fc19

Comment 14 Fedora Admin XMLRPC Client 2013-05-10 04:59:10 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 15 Fedora Update System 2013-05-10 15:33:12 UTC
Package python3-3.3.1-4.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing python3-3.3.1-4.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7855/python3-3.3.1-4.fc19
then log in and leave karma (feedback).

Comment 16 Fedora Update System 2013-05-14 04:49:06 UTC
python3-3.3.1-4.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.