Bug 960041

New upstream release:

Spec URL: http://cicku.me/liblfc-xml.spec
SRPM URL: http://cicku.me/liblfc-xml-1.1.1-1.fc20.src.rpm

New upstream release:

Spec URL: http://cicku.me/liblfc-xml.spec
SRPM URL: http://cicku.me/liblfc-xml-1.1.3-1.fc20.src.rpm

Renamed:

Spec URL: http://cicku.me/lfcxml.spec
SRPM URL: http://cicku.me/lfcxml-1.1.3-1.fc20.src.rpm

Revised version:

Spec URL: http://cicku.me/lfcxml.spec
SRPM URL: http://cicku.me/lfcxml-1.1.3-2.fc20.src.rpm

Package Review
==============

All fine so far, but:

BLOCKER:
  * -devel must have Requires: lfcbase-devel%{?_isa}
    headers do include headers from lfcbase

NON-BLOCKER, SUGGESTION:
  * %files devel
   +%doc samples/*.{cc,xml}
    %{_includedir}/%{name}/*
    %{_libdir}/*.so

WISHES, PROPOSALS:
  * contact upstream and ask to update the copyright-headers in sources
    to GPLv3+ and fix FSF-address; applies to lfcbase (and possibly
    other LEMKE-IT stuff) as well.

Fix the BLOCKERS and you'll get fedora-review(+).


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
     ---> -devel needs Requires: lfcbase-devel%{?_isa}
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 51200 bytes in 4 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
     ---> -devel Requires
[!]: Package functions as described.
     ---> -devel Requires
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: lfcxml-1.1.3-2.fc20.x86_64.rpm
          lfcxml-devel-1.1.3-2.fc20.x86_64.rpm
lfcxml.x86_64: W: spelling-error Summary(en_US) Lemke -> Lepke, Lemme
lfcxml-devel.x86_64: W: no-documentation
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLInStream.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/Attribute.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLOutStream.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLEscaper.h
2 packages and 0 specfiles checked; 4 errors, 2 warnings.

  IGNORED!


Rpmlint (installed packages)
----------------------------
# rpmlint lfcxml lfcxml-devel
lfcxml.x86_64: W: spelling-error Summary(en_US) Lemke -> Lepke, Lemme
lfcxml-devel.x86_64: W: no-documentation
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLInStream.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/Attribute.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLOutStream.h
lfcxml-devel.x86_64: E: incorrect-fsf-address /usr/include/lfcxml/XMLEscaper.h
2 packages and 0 specfiles checked; 4 errors, 2 warnings.
# echo 'rpmlint-done:'

  IGNORED!


Requires
--------
lfcxml (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    liblfcbase.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

lfcxml-devel (rpmlib, GLIBC filtered):
    lfcxml(x86-64)
    liblfcxml.so.1()(64bit)



Provides
--------
lfcxml:
    lfcxml
    lfcxml(x86-64)
    liblfcxml.so.1()(64bit)

lfcxml-devel:
    lfcxml-devel
    lfcxml-devel(x86-64)



Source checksums
----------------
http://www.lemke-it.com/lfcxml-1.1.3.tar.gz :
  CHECKSUM(SHA256) this package     : 8be054c9cb53bf012d01b21c5ca36791e3ca333d6b7aac6b7eb751e005e85da8
  CHECKSUM(SHA256) upstream package : 8be054c9cb53bf012d01b21c5ca36791e3ca333d6b7aac6b7eb751e005e85da8


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 960041

Exclude the licensing problem, all should be fixed at:

Spec URL: http://cicku.me/lfcxml.spec
SRPM URL: http://cicku.me/lfcxml-1.1.3-2.fc20.src.rpm

But one thing we should consider is the ownership of includedir, I just made the mistake in another package(monitorix), and of course lfcbase I think.

Which is:

    %{_includedir}/%{name}/*

should be replaced as:

    %{_includedir}/%{name}/

Because if I don't remove the glob, the directory itself will not be owned by RPM.

You're right. I missed that during review...
You should check and fix this in lfcbase.spec as well! I just looked in spec again and saw it's the same problem with %{_includedir}/%{name}/* --> %{_includedir}/%{name}/ there, too.

Never the less, this one is

APPROVED!

New Package SCM Request
=======================
Package Name: lfcxml
Short Description: Lemke Foundation Classes XML extension
Owners: cicku
Branches: f18 f19 el6
InitialCC:

Git done (by process-git-requests).

lfcxml-1.1.4-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.fc19

lfcxml-1.1.4-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.fc18

lfcxml-1.1.4-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/lfcxml-1.1.4-1.el6

lfcxml-1.1.4-1.fc19 has been pushed to the Fedora 19 stable repository.

lfcxml-1.1.4-1.fc18 has been pushed to the Fedora 18 stable repository.

lfcxml-1.1.4-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Package Change Request
======================
Package Name: lfcxml
New Branches: epel7
Owners: cicku

Git done (by process-git-requests).