Bug 961163

Summary: [WebTrans] shift-w and g erroneously triggers Copy from Source
Product: [Retired] Zanata Reporter: Ding-Yi Chen <dchen>
Component: Component-UIAssignee: David Mason <damason>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 2.3CC: camunoz, sflaniga, zanata-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: 2.3.2-SNAPSHOT (20130513-0001) Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-27 03:22:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Ding-Yi Chen 2013-05-09 02:09:21 UTC
Description of problem:

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Actual results:

Expected results:

Additional info:

Comment 1 Ding-Yi Chen 2013-05-09 02:17:41 UTC
Description of problem:
When input shift-w (the case does not matter) then g, it acted as if the copy from source command key, alt-g, is pressed, thus mistakenly overwrite what user have typed.

Version-Release number of selected component (if applicable):

Zanata version 2.3.1 (20130505-2134)
Zanata version 3.0.0-SNAPSHOT (20130509-0036)

How reproducible:

Steps to Reproduce:
1. In the translation editor, click on any entry.
2. Press key shift-w
3. Press key g
Actual results:
The source text is copied to target text.

Expected results:
String "Wg" or "wG" is inputted.

Additional info:

Comment 2 Carlos Munoz 2013-05-09 02:22:07 UTC
A bit more on the specifics of the scenarios that trigger the issue:

- Any string that contains the characters 'W' and 'g' will cause it.
- It has to be in that order. typing the 'g' first and then the 'W' will not cause it.
- If enough time has passed after the typing of the 'W' character, typing the 'g' will not trigger it.
- Pasting text with those characters into the editor field will not trigger it.

Comment 3 David Mason 2013-05-10 00:30:17 UTC
Fixed in 2.3.2-SNAPSHOT and merged to master. Note that this only fixes the Shift+W g behaviour, there are still several other changes to make for modal key shortcuts to behave correctly.

See: https://github.com/zanata/zanata/commit/2598c302924447edd20413e75e9b99ec594eb0b0

Comment 4 Ding-Yi Chen 2013-05-13 01:29:21 UTC
VERIFIED with Zanata version 3.0.0-SNAPSHOT (20130513-0035)
and Zanata version 2.3.2-SNAPSHOT (20130513-0001).

Comment 5 Sean Flanigan 2013-11-27 03:22:17 UTC
Closing bugs which were VERIFIED with snapshots <= 3.1.