Bug 961443

This bug report is a pretty strange one. It's filed against RHEL 5 but mentions libvirt 0.10.2-18, which is from RHEL 6.4. The latest RHEL 5 package is libvirt-0.8.2-29.el5_9.1. So what is the right RHEL release and libvirt version? Also you mention this is fixed in "later versions", what version do you mean exactly?

Terribly sorry, my fault.  You are correct, this is RHEL 6.4, I recently reinstalled the box but forgot.  I'll update the bug.

I marked this as 6.5 target, but I think it's probably very low priority (IMHO), so feel free to change it if 6.5 isn't practical.  Thanks.

The --persistent flag was changed to be backcompat alias for --config and stopped to be documented (this was expected).

Since [1] the --persistent flag is documented again with slightly different semantics than it used to have. This should be backwards compatible with the previous semantics. Please see the man page for additional info about it's behavior.

[1]:
commit 69ce3ffa8d431e9810607c6e00b7cfcc481b491d
Author: Peter Krempa <pkrempa>
Date:   Fri Mar 15 17:11:28 2013 +0100

    virsh: Fix semantics of --config for "update-device" command
    
    The man page states that with --config the next boot is affected. This
    can be understood as if _only_ the next boot was affected. This isn't
    true if the machine is running.
    
    This patch adds the full --live, --config, --current infrastructure and
    tweaks stuff to correctly support the obsolete --persistent flag.
    
    Note that this patch changes the the behavior of the --config flag to match the
    use of this flag in rest of libvirt. This flag was mistakenly renamed from
    --persistent that originaly had different semantics.

Moving to POST as I believe the commit mentioned above fixes the reported issue.

(In reply to comment #5)
> The --persistent flag was changed to be backcompat alias for --config and
> stopped to be documented (this was expected).

Are you meaning 'virsh help update-device' not mentioning --persistent was on purpose?


Yes, I do see what you describe is in the man page, that looks good.

Thanks.

(In reply to comment #7)
> (In reply to comment #5)
> > The --persistent flag was changed to be backcompat alias for --config and
> > stopped to be documented (this was expected).
> 
> Are you meaning 'virsh help update-device' not mentioning --persistent was
> on purpose?

Yes, it was on purpose, introduced by commit:

commit 1e31b8356047f2275e772f79309e9e94e15dcc6e
Author: Osier Yang <jyang>
Date:   Thu Mar 8 19:38:57 2012 +0800

    virsh: Use option alias for outmoded "--persistent"
    
    Since VIR_DOMAIN_AFFECT_{LIVE,CONFIG,CURRENT} was created,
    all new virsh commands use "--config" to represents the
    persistent changing. This patch add "--config" option
    for the old commands which still use "--persistent",
    and "--persistent" is now alias of "--config".
    
    tools/virsh.c: (use "--config", and "--persistent" is
        alias of "--config" now).
        cmdDomIfSetLink, cmdDomIfGetLink, cmdAttachDevice,
        cmdDetachDevice, cmdUpdateDevice, cmdAttachInterface,
        cmdDetachInterface, cmdAttachDisk, cmdDetachDisk
    
    toos/virsh.pod: Update docs of the changed commands, and
        add some missed docs for "--config" (detach-interface,
        detach-disk, and detach-device).

Great, thanks.

The patch from comment #5 is for bug 921407.

*** This bug has been marked as a duplicate of bug 921407 ***