Bug 961615
| Summary: | Hypervisor mount crashed after rebalance | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | distribute | Assignee: | Pranith Kumar K <pkarampu> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | high | ||
| Version: | mainline | CC: | amarts, gluster-bugs, grajaiya, jclift, rhs-bugs, sdharane, sgowda, shmohan, surs, vbellur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.4.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 960368 | Environment: |
virt rhev integration
|
| Last Closed: | 2013-07-24 17:39:52 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 960368 | ||
| Bug Blocks: | 1110456 | ||
|
Description
Pranith Kumar K
2013-05-10 05:36:45 UTC
If the following test script is executed we can see that the fuse mount crashes.
#!/bin/bash
. $(dirname $0)/../include.rc
. $(dirname $0)/../volume.rc
#This test tests that an extra fd_unref does not happen in rebalance
#migration completion check code path in dht
cleanup;
TEST glusterd
TEST pidof glusterd
TEST $CLI volume create $V0 $H0:$B0/${V0}0 $H0:$B0/${V0}1
TEST $CLI volume set $V0 performance.quick-read off
TEST $CLI volume set $V0 performance.io-cache off
TEST $CLI volume set $V0 performance.write-behind off
TEST $CLI volume set $V0 performance.stat-prefetch off
TEST $CLI volume set $V0 performance.read-ahead off
TEST $CLI volume start $V0
TEST glusterfs --volfile-id=/$V0 --volfile-server=$H0 $M0 --attribute-timeout=0 --entry-timeout=0
TEST touch $M0/1
#This rename creates a link file for 10 in the other volume.
TEST mv $M0/1 $M0/10
#Lets keep writing to the file which will trigger rebalance completion check
dd if=/dev/zero of=$M0/10 bs=1k &
bg_pid=$!
#Now rebalance force will migrate file '10'
TEST $CLI volume rebalance $V0 start force
EXPECT_WITHIN 60 "completed" rebalance_status_field $V0
#If the bug exists mount would have crashed by now
TEST ls $M0
kill -9 $bg_pid > /dev/null 2>&1
wait > /dev/null 2>&1
cleanup
REVIEW: http://review.gluster.org/4974 (cluster/dht: Don't do extra unref in dht-migration checks) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/4974 (cluster/dht: Don't do extra unref in dht-migration checks) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/4974 committed in master by Vijay Bellur (vbellur) ------ commit 2acc8c1f04d0376bedf36f1f746e542422344fa6 Author: Pranith Kumar K <pkarampu> Date: Fri May 10 10:09:13 2013 +0530 cluster/dht: Don't do extra unref in dht-migration checks Problem: syncop_open used to perform a ref in syncop_open_cbk so the extra unref was needed but now syncop_open_cbk does not take a ref so no need to do extra unref. Fix: remove the extra fd_unref and let dht_local_wipe do the final unref. Change-Id: Ibe8f9a678d456a0c7bff175306068b5cd297ecc4 BUG: 961615 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/4974 Reviewed-by: Raghavendra Bhat <raghavendra> Reviewed-by: Krishnan Parthasarathi <kparthas> Reviewed-by: Amar Tumballi <amarts> Tested-by: Gluster Build System <jenkins.com> REVIEW: http://review.gluster.org/8029 (cluster/dht: Don't do extra unref in dht-migration checks) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur) COMMIT: http://review.gluster.org/8029 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) ------ commit 2b789331dc933b186360fc8cbffb06289ee60ee9 Author: Vijay Bellur <vbellur> Date: Tue Jun 10 22:21:28 2014 +0530 cluster/dht: Don't do extra unref in dht-migration checks Problem: syncop_open used to perform a ref in syncop_open_cbk so the extra unref was needed but now syncop_open_cbk does not take a ref so no need to do extra unref. Fix: remove the extra fd_unref and let dht_local_wipe do the final unref. Change-Id: Ibe8f9a678d456a0c7bff175306068b5cd297ecc4 BUG: 961615 Signed-off-by: Pranith Kumar K <pkarampu> Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/8029 Tested-by: Gluster Build System <jenkins.com> Tested-by: Joe Julian <joe> Reviewed-by: Kaleb KEITHLEY <kkeithle> Should this be applied to release-3.5 branch as well? Only seeing mention of master and release-3.4 branches in this BZ. (In reply to Justin Clift from comment #7) > Should this be applied to release-3.5 branch as well? > > Only seeing mention of master and release-3.4 branches in this BZ. Already fixed in 3.5.0. |