Bug 961877
| Summary: | RFE: DiscoveryBoss.manuallyAddResource CLI call should use default plugin configuration when possible | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Elias Ross <genman> | ||||||
| Component: | CLI | Assignee: | Nobody <nobody> | ||||||
| Status: | NEW --- | QA Contact: | |||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 4.5 | CC: | genman, hrupp | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | Bug | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 763101 [details]
Patch for 7e512faae456
Elias, thanks for the patch - I still need to try the implications better -- especially in cases when there are more than one template and the user choose one of those and only supplied one of the values - here the other values would need to be taken from the other template instead of the default ? Thanks Heiko Yeah, I'm not sure what to do about multiple configuration templates. I forgot that RHQ had them :-) Since the client can pull the configuration template using the CLI (which I didn't figure out), might make sense to not have this change. Or maybe it would be good to have an overloaded method? DiscoveryBoss.manuallyAddResource(resourceType.id, parent.id, config, /*new*/ templateId) |
Created attachment 746211 [details] patch (for 4.5.1) DiscoveryBoss.manuallyAddResource should use default plugin configuration keys when not indicated. Alternatively, the CLI should support obtaining the default plugin configuration, allowing the settings to be overwritten on the CLI side. This is what I came up with (attached).