Bug 961904

Summary: Downloadable cartridge metadata on an application is not showing the 'url' attribute
Product: OpenShift Online Reporter: Clayton Coleman <ccoleman>
Component: MasterAssignee: Rajat Chopra <rchopra>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.xCC: jhou, rchopra, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-11 04:03:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Clayton Coleman 2013-05-10 17:17:29 UTC
Create an application based on a downloadable cartridge.  Execute:

/broker/rest/domains/abc/applications?include=cartridges

The cartridge representing the downloadable cartridge should have an attribute "url" that is equal to the value used to create the cartridge during creation.

GET /broker/rest/domains/abc/applications/cartridges
GET /broker/rest/domains/abc/applications/cartridges/<id>

should also return that value.

Blocks the UI from reporting the cartridge is custom.

Comment 1 Clayton Coleman 2013-05-10 17:53:13 UTC
Next sprint

Comment 2 Rajat Chopra 2013-05-16 17:36:30 UTC
Fixed with rev#6964cf019bf6316b53f6fe5dc1f33350c8db48cc

Comment 3 Xiaoli Tian 2013-05-17 10:40:31 UTC
Tested it on devenv_3238, created an app with 
https://raw.github.com/openshift/downloadable-mock/master/metadata/manifest.yml,
but the url is null:

#curl -s -k -H 'Content-Type: Application/json' --user xtian+t1:12
https://localhost/broker/rest/domains/domx1/applications/mockapp/cartridges/downloadable-mock-0.1
-X GET|python -m json.tool|grep url
        "license_url": "", 
        "url": null, 
# curl -s -k -H 'Content-Type: Application/json' --user xtian+t1:12
https://localhost/broker/rest/domains/domx1/applications/mockapp/cartridges -X
GET|python -m json.tool |grep url
            "license_url": "", 
            "url": null, 



# curl -s -k -H 'Content-Type: Application/json' --user xtian+t1:12
https://localhost/broker/rest/domains/domx1/applications/mockapp/cartridges -X
GET|python -m json.tool
{
    "data": [
        {
            "additional_gear_storage": 0, 
            "base_gear_storage": 1, 
            "collocated_with": [], 
            "current_scale": 1, 
            "description": "A downloadable mock cartridge for development use
only.", 
            "display_name": "Downloadable Mock Cartridge 0.1", 
            "gear_profile": "small", 
            "help_topics": {}, 
            "license": "ASL 2.0", 
            "license_url": "", 
            "links": {
                "DELETE": {
              ''''''''
             "tags": [
              "service", 
              "web_framework"
            ], 
            "type": "standalone", 
            "url": null, 
            "usage_rates": [], 
            "version": "0.1", 
            "website": 


# curl -s -k -H 'Content-Type: Application/json' --user xtian+t1:12
https://localhost/broker/rest/domains/domx1/applications/mockapp/cartridges/downloadable-mock-0.1
-X GET|python -m json.tool
{
    "data": {
        "additional_gear_storage": 0, 
        "base_gear_storage": 1, 
        "collocated_with": [], 
        "current_scale": 1, 
        "description": "A downloadable mock cartridge for development use
only.", 
        "display_name": "Downloadable Mock Cartridge 0.1", 
        "gear_profile": "small", 
        "help_topics": {}, 
        "license": "ASL 2.0", 
        "license_url": "", 
        "links": {
            "DELETE": {
                "href":
"https://localhost/broker/rest/domains/domx1/applications/mockapp/cartridges/downloadable-mock-0.1", 
                "method": "DELETE", 

 '''''''''
  "scales_from": 1, 
        "scales_to": 1, 
        "scales_with": null, 
        "status_messages": null, 
        "supported_scales_from": 1, 
        "supported_scales_to": 1, 
        "tags": [
            "service", 
            "web_framework"
        ], 
        "type": "standalone", 
        "url": null, 
        "usage_rates": [], 
        "version": "0.1", 
        "website": ""

Comment 4 Rajat Chopra 2013-05-17 15:07:52 UTC
refixed in pull request#2531

Comment 5 Clayton Coleman 2013-05-17 23:21:26 UTC
UI changes are in https://github.com/openshift/rhc/pull/386 to show this in the CLI (console is already showing it)

Comment 6 Jianwei Hou 2013-05-20 07:47:02 UTC
Verified on devenv_3247

Invoke REST API, GET:
/broker/rest/domains/abc/applications?include=cartridges
/broker/rest/domains/abc/applications/<app>/cartridges 
/broker/rest/domains/abc/applications/<app>/cartridges/<cartridge>

The cartridge"type": "standalone",
        "url": "https://raw.github.com/xltian/perltestonly/master/metadata/manifest.yml",
        "usage_rates": [
 url can be returned:
<-------------------------->
..................
"type": "standalone",
        "url": "https://raw.github.com/xltian/perltestonly/master/metadata/manifest.yml",
        "usage_rates": [
............
<-------------------------->