Bug 962069

Summary: Use pid file for checking status
Product: [Fedora] Fedora EPEL Reporter: Ruben Kerkhof <ruben>
Component: shellinaboxAssignee: Simone Caronni <negativo17>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: el6CC: negativo17
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-03 10:20:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ruben Kerkhof 2013-05-11 13:29:53 UTC
Description of problem:

service shellinaboxd stop just stopped my shellinabox processes which were running under supervisor. It shouldn't do that, but use the pidfile to decide which processes to kill.

This can be fixed by applying:

diff --git a/shellinaboxd.init b/shellinaboxd.init
index db7c55e..f62c4aa 100644
--- a/shellinaboxd.init
+++ b/shellinaboxd.init
@@ -46,7 +46,7 @@ start() {
 
 stop() {
     echo -n $"Stopping $prog: "
-    killproc $prog
+    killproc -p /var/run/$prog.pid $prog
     retval=$?
     echo
     [ $retval -eq 0 ] && rm -f $lockfile
@@ -68,7 +68,7 @@ force_reload() {
 
 rh_status() {
     # run checks to determine if the service is running or use generic status
-    status $prog
+    status -p /var/run/$prog.pid $prog
 }

Comment 1 Fedora Update System 2013-05-11 17:12:54 UTC
shellinabox-2.14-22.git88822c1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/shellinabox-2.14-22.git88822c1.fc19

Comment 2 Fedora Update System 2013-05-11 17:13:12 UTC
shellinabox-2.14-22.git88822c1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/shellinabox-2.14-22.git88822c1.fc18

Comment 3 Fedora Update System 2013-05-11 17:13:31 UTC
shellinabox-2.14-22.git88822c1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/shellinabox-2.14-22.git88822c1.fc17

Comment 4 Fedora Update System 2013-05-11 17:14:00 UTC
shellinabox-2.14-22.git88822c1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/shellinabox-2.14-22.git88822c1.el6

Comment 5 Fedora Update System 2013-05-11 17:14:18 UTC
shellinabox-2.14-22.git88822c1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/shellinabox-2.14-22.git88822c1.el5

Comment 6 Fedora Update System 2013-05-23 12:34:03 UTC
shellinabox-2.14-22.git88822c1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2013-05-23 12:34:43 UTC
shellinabox-2.14-22.git88822c1.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-05-24 20:46:31 UTC
shellinabox-2.14-22.git88822c1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-05-28 19:36:11 UTC
shellinabox-2.14-22.git88822c1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2013-05-28 19:38:21 UTC
shellinabox-2.14-22.git88822c1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.