Bug 962581
| Summary: | Review Request: arm-boot-config - ARM boot configuration generator for uboot | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brendan Conoboy <blc> |
| Component: | Package Review | Assignee: | Dennis Gilmore <dennis> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dennis, dgilmore, kwizart, notting, package-review, pbrobinson |
| Target Milestone: | --- | Flags: | dennis:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-18 09:09:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Brendan Conoboy
2013-05-14 00:21:22 UTC
I will review this i did a scratch build at http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1809970 rpmlint Descargas/arm-boot-config-0.42-1.fc19.* arm-boot-config.armv7hl: W: incoherent-version-in-changelog 0.40 ['0.42-1.fc19', '0.42-1'] arm-boot-config.armv7hl: E: no-binary arm-boot-config.armv7hl: W: no-documentation arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/15-defaults arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-armadaxp arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-calxeda arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-tegra arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/95-genmen arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/90-complete arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/99-autoboot arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-arndale arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-allwinner arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/20-ti-board arm-boot-config.armv7hl: E: executable-marked-as-config-file /etc/a-b-c.d/25-postscan-results arm-boot-config.armv7hl: W: no-manual-page-for-binary a-b-c arm-boot-config.armv7hl: W: one-line-command-in-%post /sbin/a-b-c arm-boot-config.src: W: invalid-url Source0: arm-boot-config-0.42.tar.bz2 2 packages and 0 specfiles checked; 12 errors, 5 warnings. you should change the %post section to be "%post -p /usr/sbin/a-b-c" changelog version doesnt match the package version you should remove the shebangs from the files in /etc/a-b-c.d/ so they dont get marked as executable Thanks for feedback. Updated. http://people.fedoraproject.org/~blc/fedora-arm/arm-boot-config/arm-boot-config.spec http://people.fedoraproject.org/~blc/fedora-arm/arm-boot-config/arm-boot-config-0.43-1.fc19.src.rpm rpmlint arm-boot-config-0.43-1.fc19.armv7hl.rpm arm-boot-config.armv7hl: E: no-binary arm-boot-config.armv7hl: W: no-manual-page-for-binary a-b-c 1 packages and 0 specfiles checked; 1 errors, 1 warnings. since the package is architecture specific we can ignore the no-binary error. approved New Package SCM Request ======================= Package Name: arm-boot-config Short Description: ARM boot configuration engine. Owners: blc Branches: f19 InitialCC: dgilmore Git done (by process-git-requests). |