Bug 962666

> Enter UserDefinedVMProperties containing chars other then ';', '=',
> ,[a-z_A-Z0-9]
>   

other than... :/

Moti told me, that there's no UserDefinedVMProperties validator defined in engine-config tool. I will create such validator for UserDefinedVMProperties (so only valid properties could be entered) as soon as device custom properties patch will be ready, because it changes many things in VMPropertiesUtils class.

(In reply to comment #3)
> Moti told me, that there's no UserDefinedVMProperties validator defined in
> engine-config tool. I will create such validator for UserDefinedVMProperties
> (so only valid properties could be entered) as soon as device custom
> properties patch will be ready, because it changes many things in
> VMPropertiesUtils class.

I agree with this path.
Can you please asses how long it will take you to come up with such validator (based on the fact you need to require a validator for custom device properties)

Please write exactly what you write under UserDefinedVMProperties, that after this engine stack?
Enter special characters, also tried Russian symbols, engine work fine and do restart without problem  
rhevm-config -s UserDefinedVMProperties='test=$%2as'
Please select a version:
1. 3.0
2. 3.1
3. 3.2
4. 3.3
4
[root@artyom-rhevm-33 ~]# rhevm-config -g UserDefinedVMProperties
UserDefinedVMProperties:  version: 3.0
UserDefinedVMProperties:  version: 3.1
UserDefinedVMProperties:  version: 3.2
UserDefinedVMProperties: test=$%2as version: 3.3
[root@artyom-rhevm-33 ~]# service ovirt-engine restart
Stopping oVirt Engine:                                     [  OK  ]
Starting oVirt Engine:                                     [  OK  ]
[root@artyom-rhevm-33 ~]# rhevm-config -s UserDefinedVMProperties='test=фыв'
Please select a version:
1. 3.0
2. 3.1
3. 3.2
4. 3.3
4
[root@artyom-rhevm-33 ~]# service ovirt-engine restart
Stopping oVirt Engine:                                     [  OK  ]
Starting oVirt Engine:                                     [  OK  ]
[root@artyom-rhevm-33 ~]# rhevm-config -g UserDefinedVMProperties
UserDefinedVMProperties:  version: 3.0
UserDefinedVMProperties:  version: 3.1
UserDefinedVMProperties:  version: 3.2
UserDefinedVMProperties: test=фыв version: 3.3

also create vm with this custom parameter

about patch, still no any validation on input for rhevm-config -s UserDefinedVMProperties

All your tests contains only valid characters for property definition. Currently there are these rules for properties:

1) Property name can contain only upper/lower case, number or underscore
2) Property value can contain every characters except semicolon

So if you try following examples, you will receive validation errors, but before patch 14914, those values would be ok, but engine wouldn't start:

engine-config -s UserDefinedVMProperties='te#st=1'
engine-config -s UserDefinedVMProperties='test=1;3'


But watch out for this example:

engine-config -s UserDefinedVMProperties='test=1;'

This one will not throw an error, because semicolon is used as property definition delimiter, so property with name 'test' and value '1' will be created.

Trying examples from comment above receive message:
"Cannot set value test=1;3 to key UserDefinedVMProperties. Invalid syntax, user defined VM properties specification should conform to (([a-z_A-Z0-9])+)=(([^;])+)(;(([a-z_A-Z0-9])+)=(([^;])+))*;?"
Verified on is12

Closing - RHEV 3.3 Released

Closing - RHEV 3.3 Released