Bug 962820
Summary: | Review Request: pngquant - PNG quantization tool for reducing image file size | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Björn 'besser82' Esser <besser82> |
Component: | Package Review | Assignee: | Christopher Meng <i> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bugs.michael, i, notting, package-review |
Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://pngquant.org/ | ||
Whiteboard: | https://github.com/pornel/improved-pngquant | ||
Fixed In Version: | pngquant-1.8.3-6.el6 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-05-21 20:29:29 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Björn 'besser82' Esser
2013-05-14 13:59:04 UTC
First, IMO, to keep it simple and readable, I hope you can Name: Version: Release: Summary: License: URL: Source0: Keep them in order I think. Next I would leave the URL with pngquant not %{name}...It seems you use %name to cover everything :D...but whatever you want. Let's continue, for BuildRequires: libpng-devel >= 1.2.46-1 I think no need to specify the version required, latest version in Fedora is 1.5.x, and even in EL6 it's 1.2.49. Last, in the %prep section %setup -q is enough, no need for -n to define "%{name}-%{version}". And finally the fedora review: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [x] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package complies to the Packaging Guidelines [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 3 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: pngquant-1.8.3-1.fc20.i686.rpm pngquant.i686: W: spelling-error Summary(en_US) quantization -> quantification, equalization, tantalization pngquant.i686: W: spelling-error %description -l en_US Quantized -> Quarantined, Antiquated, Antiqued 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Ignored. Rpmlint (installed packages) ---------------------------- # rpmlint pngquant pngquant.i686: W: spelling-error Summary(en_US) quantization -> quantification, equalization, tantalization pngquant.i686: W: spelling-error %description -l en_US Quantized -> Quarantined, Antiquated, Antiqued 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Ignored. Requires -------- pngquant (rpmlib, GLIBC filtered): libc.so.6 libm.so.6 libpng15.so.15 libpng15.so.15(PNG15_0) rtld(GNU_HASH) Provides -------- pngquant: pngquant pngquant(x86-32) Source checksums ---------------- http://pngquant.org/pngquant-1.8.3-src.tar.bz2 : CHECKSUM(SHA256) this package : e3d18b12ddf4ee159a696408b147d667674e52121f11660fc15ce3967dd053b9 CHECKSUM(SHA256) upstream package : e3d18b12ddf4ee159a696408b147d667674e52121f11660fc15ce3967dd053b9 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-rawhide-i386 Command line :/usr/bin/fedora-review -rn pngquant-1.8.3-1.fc18.src.rpm -v Please consider an enhancement of my advice. Alright, APPROVED. > %setup -q is enough, no need for -n to define "%{name}-%{version}" The longer explanation gives some background: "-n %name-%version" is the default, but if one ever wants to package a snapshot, one will likely need "-n …". By quite some packagers it's considered more convenient to simply adjust/change an existing "-n …" rather than delete it completely and add it back again when needed for e.g. a temporary snapshot once again. * The second license in file COPYRIGHT looks like "License: BSD with advertising": https://fedoraproject.org/wiki/Licensing:BSD allright, will do the suggested changes in SCM, then. New Package SCM Request ======================= Package Name: pngquant Short Description: PNG quantization tool for reducing image file size Owners: besser82 Branches: f18 f19 Bjrön, try to be more careful with the review flags. Christopher will need to approve this one again, because the flags are connected to the user, who sets them. If you set it to '+', it appears as if you've approved your own package. http://fedoraproject.org/wiki/Package_Review_Process#Definitions_for_fedora-review_Flag_Settings Spec URL: http://besser82.fedorapeople.org/pkg/pngquant/pngquant.spec SRPM URL: http://besser82.fedorapeople.org/pkg/pngquant/pngquant-1.8.3-2.fc18.src.rpm I'll be more careful with the flags next time I promise! So here's a version with the suggested changes from above. Thanks for review, Christopher! Git done (by process-git-requests). pngquant-1.8.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pngquant-1.8.3-2.fc18 pngquant-1.8.3-2.fc19 has been pushed to the Fedora 19 testing repository. pngquant-1.8.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pngquant-1.8.3-3.fc18 pngquant-1.8.3-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pngquant-1.8.3-3.fc19 Package Change Request ====================== Package Name: pngquant New Branches: el5 el6 Owners: besser82 Git done (by process-git-requests). pngquant-1.8.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pngquant-1.8.3-3.el6 pngquant-1.8.3-5.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pngquant-1.8.3-5.el5 pngquant-1.8.3-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pngquant-1.8.3-5.el6 pngquant-1.8.3-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pngquant-1.8.3-5.fc18 pngquant-1.8.3-5.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pngquant-1.8.3-5.fc19 pngquant-1.8.3-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pngquant-1.8.3-6.el5 pngquant-1.8.3-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/pngquant-1.8.3-6.el6 pngquant-1.8.3-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pngquant-1.8.3-6.fc18 pngquant-1.8.3-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/pngquant-1.8.3-6.fc19 pngquant-1.8.3-6.fc18 has been pushed to the Fedora 18 stable repository. pngquant-1.8.3-6.fc19 has been pushed to the Fedora 19 stable repository. pngquant-1.8.3-6.el5 has been pushed to the Fedora EPEL 5 stable repository. pngquant-1.8.3-6.el6 has been pushed to the Fedora EPEL 6 stable repository. |