Bug 963055

Summary: "vncviewer --AcceptClipboard=0" accepts clipboard updates
Product: [Fedora] Fedora Reporter: Matt McCutchen <matt>
Component: tigervncAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: bphinz, ossman, twaugh
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: tigervnc-1.3.0-3.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-28 01:05:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix none

Description Matt McCutchen 2013-05-15 04:27:45 UTC 
Description of problem:
The viewer accepts clipboard updates from the server even when --AcceptClipboard=0 is passed on the command line.

I want to be able to copy and paste between local applications while a VNC session to an untrusted account is running without risk of the VNC session overwriting my local clipboard with harmful content without notice.  To do so, I need to configure the viewer not to accept clipboard updates.  (I have a separate script to copy data between the local and remote clipboards when I request it.)

Version-Release number of selected component (if applicable):
tigervnc-1.2.80-0.10.20130314svn5065.fc18.x86_64

How reproducible:
Always

Steps to Reproduce:
1. vncserver :2 (or some available display number)
2. vncviewer --AcceptClipboard=0 :2
3. In the VNC session, copy something to the clipboard.
4. Go to a window outside the VNC session and paste.

Actual results:
The content from the VNC session is pasted.

Expected results:
The content previously on the local clipboard, if any, is pasted.
Comment 1 Matt McCutchen 2013-05-15 04:34:07 UTC 
Created attachment 748055 [details]
Fix

I rebuilt the tigervnc RPMs with the attached patch and it seems to fix the problem.

It looks like the conditional on acceptClipboard was lost in the move to the "new FLTK viewer" (upstream SVN r4345).  Ideally I would take this bug upstream; we'll see if I get around to it.
Comment 2 Pierre Ossman 2013-05-24 10:48:03 UTC 
Thanks for spotting this. Will be in the next upstream release. :)
Comment 3 Tim Waugh 2013-07-08 16:35:15 UTC 
Should be fixed in tigervnc-1.3.0-1.fc19.
Comment 4 Fedora Update System 2013-07-08 16:38:15 UTC 
tigervnc-1.3.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tigervnc-1.3.0-1.fc19
Comment 5 Fedora Update System 2013-07-24 16:52:04 UTC 
tigervnc-1.3.0-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tigervnc-1.3.0-3.fc19
Comment 6 Fedora Update System 2013-07-26 00:36:23 UTC 
Package tigervnc-1.3.0-3.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing tigervnc-1.3.0-3.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-13650/tigervnc-1.3.0-3.fc19
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2013-07-28 01:05:16 UTC 
tigervnc-1.3.0-3.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.