Bug 963085

Summary: pmatop fails to start
Product: [Fedora] Fedora EPEL Reporter: Marko Myllynen <myllynen>
Component: pcpAssignee: Stan Cox <scox>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: el6CC: fche, mgoodwin, nathans
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcp-3.8.2-1.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-16 19:52:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marko Myllynen 2013-05-15 06:32:15 UTC
Description of problem:
localhost:~> rpm -q pcp
pcp-3.8.0-1.el6.x86_64
localhost:~> sudo rpm -V pcp
missing     /var/lib/pcp/pmns/.NeedRebuild
localhost:~> pmatop
Traceback (most recent call last):
  File "/usr/bin/pmatop", line 765, in <module>
    status = curses.wrapper(main)   # pylint: disable-msg=C0103
  File "/usr/lib64/python2.6/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/usr/bin/pmatop", line 643, in main
    proc.setup_metrics (pmc)
  File "/usr/lib64/python2.6/site-packages/pcp/pmsubsys.py", line 65, in setup_metrics
    raise pmErr, (c_api.PM_ERR_NAME, "", name_pattern)
pcp.pmapi.pmErr: PM_ERR_NAME Unknown metric name: proc.*
localhost:~> service pmcd status
Checking for pmcd: running
localhost:~>

Comment 1 Frank Ch. Eigler 2013-05-15 13:30:41 UTC
pmatop appears to require the proc PMDA to be activated, as in
# cd /var/lib/pcp/pmdas/proc; ./Install

pmatop should offer this advice if it detects the problem, rather
than letting a low level exception propagate out.  (How much can
pmatop do without proc.*?)

Comment 2 Fedora Update System 2013-06-19 07:40:23 UTC
pcp-3.8.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pcp-3.8.1-1.el6

Comment 3 Fedora Update System 2013-07-04 20:02:03 UTC
pcp-3.8.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 4 Marko Myllynen 2013-07-05 06:09:26 UTC
With 3.8.1 I'm getting this both before and after the activation:

localhost:~> rpm -q pcp
pcp-3.8.1-1.el6.x86_64
localhost:~> sudo rpm -V pcp
missing     /var/lib/pcp/pmns/.NeedRebuild
localhost:~> pmatop
Traceback (most recent call last):
  File "/usr/bin/pmatop", line 732, in <module>
    status = curses.wrapper(main)   # pylint: disable-msg=C0103
  File "/usr/lib64/python2.6/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/usr/bin/pmatop", line 670, in main
    stdscr.move (proc.command_line, 0)
AttributeError: '_ProcPrint' object has no attribute 'command_line'
localhost:~> service pmcd status
Checking for pmcd: running
localhost:~>

Comment 5 Fedora Update System 2013-07-31 04:41:50 UTC
pcp-3.8.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/pcp-3.8.2-1.fc19

Comment 6 Fedora Update System 2013-07-31 05:17:12 UTC
pcp-3.8.2-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/pcp-3.8.2-1.fc18

Comment 7 Fedora Update System 2013-07-31 05:18:08 UTC
pcp-3.8.2-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/pcp-3.8.2-1.fc17

Comment 8 Fedora Update System 2013-07-31 05:19:06 UTC
pcp-3.8.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pcp-3.8.2-1.el6

Comment 9 Fedora Update System 2013-07-31 05:19:59 UTC
pcp-3.8.2-1.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/pcp-3.8.2-1.el5

Comment 10 Fedora Update System 2013-08-01 20:33:27 UTC
Package pcp-3.8.2-1.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing pcp-3.8.2-1.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11023/pcp-3.8.2-1.el6
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2013-08-02 03:47:53 UTC
pcp-3.8.2-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Frank Ch. Eigler 2013-08-05 15:10:56 UTC
Note that the pcp 3.8.1 -> 3.8.2 upgrade preserves a modified pmcd.conf,
so the newly-default proc pmda will not be activated by default.  Worse,
the proc pmda's /var/lib/pcp/pmdas directory lacks Install/Remove scripts,
so one can't activate them by hand either.  In my case, I opted to have
rpm overwrite the pmcd.conf during a yum reinstall to get this working.

Comment 13 Marko Myllynen 2013-08-05 15:48:12 UTC
(In reply to Frank Ch. Eigler from comment #12)
> Note that the pcp 3.8.1 -> 3.8.2 upgrade preserves a modified pmcd.conf,
> so the newly-default proc pmda will not be activated by default.  Worse,
> the proc pmda's /var/lib/pcp/pmdas directory lacks Install/Remove scripts,
> so one can't activate them by hand either.  In my case, I opted to have
> rpm overwrite the pmcd.conf during a yum reinstall to get this working.

Right, so how one should start using pmatop after installing 3.8.2 for the first time on a system?

Comment 14 Frank Ch. Eigler 2013-08-05 15:59:27 UTC
That should Just Work (tm); % sudo service pmcd start; pmatop

Comment 15 Marko Myllynen 2013-08-05 16:04:51 UTC
(In reply to Frank Ch. Eigler from comment #14)
> That should Just Work (tm); % sudo service pmcd start; pmatop

Nope, it's still the same as before:

localhost:~> rpm -q pcp
pcp-3.8.2-1.el6.x86_64
localhost:~> sudo rpm -V pcp
missing     /var/lib/pcp/pmns/.NeedRebuild
localhost:~> pmatop
Traceback (most recent call last):
  File "/usr/bin/pmatop", line 741, in <module>
    status = curses.wrapper(main)   # pylint: disable-msg=C0103
  File "/usr/lib64/python2.6/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/usr/bin/pmatop", line 679, in main
    stdscr.move (proc.command_line, 0)
AttributeError: '_ProcPrint' object has no attribute 'command_line'
localhost:~> service pmcd status
Checking for pmcd: running
localhost:~>

Comment 16 Marko Myllynen 2013-08-05 19:16:36 UTC
Interestingly, the error is printed when using a standard 80x24 terminal but pmatop starts up nicely when the terminal used is at least 80x28.

Comment 17 Stan Cox 2013-08-05 20:48:57 UTC
sourceware.org/git/pcpfans.git 
branch scox/dev 
commit bd98b690b7605f7af779ea843f4682214f02f24c
Author: Stan Cox <scox>
Date:   Mon Aug 5 16:44:21 2013 -0400
    Fix pmatop interactive help.
    * pmatop (main):  Display interactive help on its own screen.

Comment 18 Fedora Update System 2013-08-05 23:28:56 UTC
pcp-3.8.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 19 Stan Cox 2013-08-08 22:27:51 UTC
sourceware.org/git/pcpfans.git
branch scox/dev
commit feb87493a9239be489c9d2ab66433c430b637207
Author: Stan Cox <scox>
Date:   Thu Aug 8 18:28:01 2013 -0400
Decrease screen real estate used for display.
* pmatop.py (_AtopPrint): Add end_of_screen.  Use throughout.
(_ProcessorPrint): Don't display cpus with no activity in interval.
(_DiskPrint): Likewise for lvm.
(_NetPrint): Lisewise for net.

Comment 20 Marko Myllynen 2013-08-09 06:36:43 UTC
Hi Stan,

I'm happy to confirm that pmatop of pcpfans scox/dev feb87493 now finally starts up correctly also on a standard 80x24 terminal.

Thanks!

Comment 21 Fedora Update System 2013-08-10 04:01:32 UTC
pcp-3.8.2-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 22 Fedora Update System 2013-08-10 12:33:10 UTC
pcp-3.8.2-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 23 Marko Myllynen 2013-08-13 06:26:29 UTC
Patch upstream, will be part of 3.8.3 (not 3.8.2).

Comment 24 Fedora Update System 2013-08-16 19:52:47 UTC
pcp-3.8.2-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.