Bug 963339
Summary: | Review Request: libyui-bindings - Language bindings for libyui | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Björn 'besser82' Esser <besser82> |
Component: | Package Review | Assignee: | Christopher Meng <i> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bugs.michael, i |
Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/libyui/libyui-bindings/ | ||
Whiteboard: | |||
Fixed In Version: | libyui-bindings-1.0.1-2.fc19 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-05-21 20:29:41 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 959926 | ||
Bug Blocks: |
Description
Björn 'besser82' Esser
2013-05-15 17:14:26 UTC
Hint: https://fedoraproject.org/wiki/Package_Review_Process#Definitions_for_fedora-review_Flag_Settings Quick look into spec: 1) As I've said before, keep it readable...Orders;No empty line between group tag and summary tag in subpackages 2)Too many %global, just use %{name} with libyui-bindings, why not? Fix the BR by remove %global libyui_devel_version %{libname}-devel >= 3.0.3 with BuildRequires: libyui-devel >= 3.0.3. BTW is ">= 3.0.3" really required? Spec URL: http://besser82.fedorapeople.org/pkg/libyui-bindings/libyui-bindings.spec SRPM URL: http://besser82.fedorapeople.org/pkg/libyui-bindings/libyui-bindings-1.0.1-2.fc18.src.rpm > 1) As I've said before, keep it readable...Orders;No empty line between group tag and summary tag in subpackages > Fix the BR by remove %global libyui_devel_version %{libname}-devel >= 3.0.3 with BuildRequires: libyui-devel >= 3.0.3. fixed > BTW is ">= 3.0.3" really required? Nope. Just took that in during c&p from other libyui*.spec 2)Too many %global, just use %{name} with libyui-bindings, why not? It's just two %global (libsuffix = yui and libname = lib%{libsuffix}) besides the obligatory %commit and %shortcommit (lib)yui is used rather often inside the spec. I think spec-file should be easy adoptable for other similar purpose, without doing lots of search-replace, just changing libsuffix to what's needed, then. BTW: In the other libyui*-spec I have similar %global..., so I want keep this consistent. SPEC seems not changed? Ups! synced before saving the modded spec... Try again, now. (In reply to comment #5) > Ups! synced before saving the modded spec... Try again, now. What did you change? changes in spec: * order of spec-tags (URL,Source,Group,etc) * no empty line between group tag and summary tag in subpackages * remove %global libyui_devel_version %{libname}-devel >= 3.0.3 * changed BuildRequires: %{libyui_devel_version} --> BuildRequires: %{libname}-devel >= 3.0.3 * remove ">= 3.0.3" on BuildRequires * now it reads: BuildRequires: %{libname}-devel (In reply to comment #7) But http://besser82.fedorapeople.org/pkg/libyui-bindings/libyui-bindings.spec doesn't change anything. The problem was that needed to re-gen srpm from changed spec... Synced. Alright. APPROVED. New Package SCM Request ======================= Package Name: libyui-bindings Short Description: Language bindings for libyui Owners: besser82 Branches: f18 f19 Git done (by process-git-requests). libyui-bindings-1.0.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libyui-bindings-1.0.1-2.fc19 libyui-bindings-1.0.1-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libyui-bindings-1.0.1-2.fc18 libyui-bindings-1.0.1-2.fc19 has been pushed to the Fedora 19 testing repository. libyui-bindings-1.0.1-2.fc18 has been pushed to the Fedora 18 stable repository. libyui-bindings-1.0.1-2.fc19 has been pushed to the Fedora 19 stable repository. Package Change Request ====================== Package Name: libyui New Branches: el6 Owners: besser82 Want to build on el6, too. Package Change Request ====================== Package Name: libyui-bindings New Branches: el6 Owners: besser82 Want to build on el6, too. Git done (by process-git-requests). |