Bug 963428

Summary:	With every new open file (song), six DIR filehandles stay open
Product:	[Fedora] Fedora	Reporter:	Jan Pazdziora <jpazdziora>
Component:	parole	Assignee:	Christoph Wickert <christoph.wickert>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	christoph.wickert, jpazdziora, kevin, rosset.filipe
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	parole-0.5.4-2.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-16 07:07:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Pazdziora 2013-05-15 19:02:51 UTC

Description of problem:

Whenever new file is selected to play, the number of DIR filehandles increases by six. Eventually parole rejects to play the next song because it reaches too many open files.

Version-Release number of selected component (if applicable):

# rpm -q parole
parole-0.5.0-1.fc18.i686

How reproducible:

Deterministic.

Steps to Reproduce:
1. Start parole.
2. Get its pid.
3. Run lsof -p $the_pid.
4. Hit Ctrl + O and select some .ogg file, play it.
5. Hit Ctrl + O again and select different .ogg file, from different directory.
3. Run lsof -p $the_pid again.
  
Actual results:

There are six DIR filehandles of the first directory and six for the other one.
If you select the first file again, there will be six more.

Expected results:

The number of open files should not grow with every new song played.

Additional info:

Comment 1 Jan Pazdziora 2013-11-06 07:41:49 UTC

Bug is still present with parole-0.5.2-1.fc19.x86_64.

Comment 2 Filipe Rosset 2013-12-21 19:12:14 UTC

Hi Jan, can you please take a look if it's still present with parole 0.5.4?
If its still present I believe we should file a bug with upstream guys.

Comment 3 Filipe Rosset 2013-12-21 19:14:38 UTC

F20 - https://admin.fedoraproject.org/updates/parole-0.5.4-1.fc20

Comment 4 Jan Pazdziora 2013-12-22 10:06:04 UTC

I don't have local Fedora 20 installation to try. What behaviour do you observe on your installation with the steps from comment 0? Is there anything in 0.5.4's changelog suggesting it's been fixed?

Comment 5 Filipe Rosset 2014-01-03 22:44:08 UTC

Hi Jan, I can confirm the issue, but here with parole-0.5.4-1.fc20.x86_64 the number of DIR filehandles are 4 instead of 6. I'm not sure if something was changed in the code to use less filehanles than the older version.

Comment 6 Filipe Rosset 2014-01-03 22:50:42 UTC

Filled a bug upstream: https://bugzilla.xfce.org/show_bug.cgi?id=10600

Comment 7 Filipe Rosset 2014-01-04 00:46:35 UTC

Great, upstream fixed in http://git.xfce.org/apps/parole/commit/?id=61821b73c94fa8f498fe3fe78a8fc686295275f8

Will be fixed in next 0.5.x upstream release.

Comment 8 Jan Pazdziora 2014-01-04 02:33:59 UTC

(In reply to Filipe Rosset from comment #6)
> Filled a bug upstream: https://bugzilla.xfce.org/show_bug.cgi?id=10600

Thank you.

Comment 9 Jan Pazdziora 2014-01-04 02:35:27 UTC

Bumping up the version per comment 5.

Comment 10 Fedora Update System 2014-01-04 21:30:29 UTC

parole-0.5.4-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/parole-0.5.4-2.fc19

Comment 11 Fedora Update System 2014-01-04 21:31:19 UTC

parole-0.5.4-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/parole-0.5.4-2.fc20

Comment 12 Fedora Update System 2014-01-05 12:33:12 UTC

Package parole-0.5.4-2.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing parole-0.5.4-2.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0251/parole-0.5.4-2.fc20
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2014-01-16 07:07:46 UTC

parole-0.5.4-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2014-01-16 07:15:30 UTC

parole-0.5.4-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.