Bug 963604

Summary:	Review Request: python-pdfrw - Python library to read and write PDF files
Product:	[Fedora] Fedora	Reporter:	Sergio Pascual <sergio.pasra>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-05-23 14:06:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	957835

Description Sergio Pascual 2013-05-16 08:31:11 UTC

Spec URL: http://sergiopr.fedorapeople.org/python-pdfrw.spec
SRPM URL: http://sergiopr.fedorapeople.org/python-pdfrw-0.1-1.fc18.src.rpm
Description: pdfrw is a basic PDF file manipulation library. Developed and tested on Python 2.5-2.7,  pdfrw can read and write PDF files, and can also 
be used to read in PDFs which can then be used inside reportlab.
Fedora Account System Username: sergiopr

Comment 1 Parag AN(पराग) 2013-05-22 06:08:14 UTC

Review:

+ mock build succeeded for rawhide

+ rpmlint on rpms gave
python-pdfrw.noarch: W: spelling-error %description -l en_US reportlab -> report lab, report-lab, reportorial
python-pdfrw.src: W: spelling-error %description -l en_US reportlab -> report lab, report-lab, reportorial
python-pdfrw.src: W: invalid-url Source0: http://pdfrw.googlecode.com/files/pdfrw_0.1.zip HTTP Error 404: Not Found
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as 
http://pdfrw.googlecode.com/files/pdfrw_0.1.zip :
  CHECKSUM(SHA256) this package     : 4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919
  CHECKSUM(SHA256) upstream package : 4dbb4017b179f1ecee947501d178a90e1ff0aaf6444ef24b5a630ee68e884919

+ Package follows packaging guidelines.

suggestions:
1) you don't need following in %install in spec now for Fedora branches.
rm -rf %{buildroot}

2) See if you can package examples directory as %docs but this will make rpmlint to complain doc-file-dependency warning which can be fixed by 
sed -i '1d' <required files to be removed /usr/bin/env>


APPROVED.

Comment 2 Sergio Pascual 2013-05-23 11:27:31 UTC

Thanks for the review, I have updated the spec to follow your suggestions

Comment 3 Sergio Pascual 2013-05-23 11:32:56 UTC

New Package SCM Request
=======================
Package Name: python-pdfrw
Short Description: Python library to read and write PDF files
Owners: sergiopr
Branches: f17 f18 f19
InitialCC:

Comment 4 Gwyn Ciesla 2013-05-23 12:59:39 UTC

Git done (by process-git-requests).