Bug 963681

Summary: Can we conditionalize /usr/lib/systemd/system/ksmtuned.service?
Product: [Fedora] Fedora Reporter: Lennart Poettering <lpoetter>
Component: qemuAssignee: Fedora Virtualization Maintainers <virt-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: amit.shah, berrange, cfergeau, crobinso, dwmw2, ignatenko, itamar, pbonzini, rjones, scottt.tw, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-1.4.2-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-01 03:20:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lennart Poettering 2013-05-16 11:33:55 UTC
Currently, if qemu is installed it will unconditionally install ksmtuned.service and turn it on. Do we still need this? Doesn't the kernel do this automatically these days?

If this really shall stay, could we at least conditionalize it to run it only on the host, not in a VM? Please add ConditionVirtualization=no for that to the unit file.

Comment 1 Lennart Poettering 2013-05-16 11:34:48 UTC
Also see comments on:

https://lists.fedoraproject.org/pipermail/devel/2013-May/182750.html

(near the end).

Something similar applies to ksm.service of course.

Comment 2 Paolo Bonzini 2013-05-16 14:36:00 UTC
Definitely true that ksmtuned.service needs ConditionVirtualization=no.

ksm.service in principle could be used on non-virt usecases too, but in the end it makes sense to add it there too.

Comment 3 Cole Robinson 2013-05-25 18:35:39 UTC
I'll add ConditionVirtualization=no to ksm*.service

I'm also splitting KSM into its own subpackage, so it isn't pulled in for every qemu install. I don't think the average Fedora user gets much use from it, yet every few months for 3+ years I see a complaint like 'wtf is KSM and why is it using X% of my cpu?'

If people know what it is and want it, it's just a 'yum install ksm' away

Comment 4 Fedora Update System 2013-05-25 19:43:56 UTC
qemu-1.4.2-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.2-1.fc19

Comment 5 Fedora Update System 2013-05-26 16:59:59 UTC
Package qemu-1.4.2-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qemu-1.4.2-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9287/qemu-1.4.2-1.fc19
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-05-27 13:13:32 UTC
qemu-1.4.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.2-2.fc19

Comment 7 Fedora Update System 2013-06-01 03:20:42 UTC
qemu-1.4.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.