Bug 963903
| Summary: | Review Request: perl-Net-INET6Glue - Make common modules IPv6 ready by hotpatching | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ken Dreyer <ktdreyer> |
| Component: | Package Review | Assignee: | Ralf Corsepius <rc040203> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, rc040203 |
| Target Milestone: | --- | Flags: | rc040203:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Net-INET6Glue-0.5-3.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-27 00:31:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ken Dreyer
2013-05-16 18:35:16 UTC
(In reply to comment #0) > (I won't be supporting EL5 in this package.) Non-issue: AFAICT, in this case, you can remove BuildRoot, rm -rf %{buildroot} etc. from the spec (I currently can't verify). However, there is one major issue: This package's Makefile.PL expects interactive input: This causes rpmbuild'ing the package (outside of mock) to wait for keyboard input, i.e. rpmbuild to hang: # rpmbuild --rebuild /tmp/perl-Net-INET6Glue-0.5-1.fc20.src.rpm ... Should I do external tests? These tests will fail if there is no internet connection or if a firewall blocks active or passive IPv6 FTP traffic. [y/N] [n] Thanks Ralf, here's release 2. * Sun May 19 2013 Ken Dreyer <ktdreyer> 0.5-2 - Run Makefile.pl with PERL_MM_USE_DEFAULT=1 so that we skip the prompt during an interactive rpmbuild session (eg. outside of mock). - Remove BuildRoot and rm -rf $RPM_BUILD_ROOT. (EL5 compat not required.) Spec URL: http://ktdreyer.fedorapeople.org/reviews/perl-Net-INET6Glue.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/perl-Net-INET6Glue-0.5-2.fc20.src.rpm Sorry, for this review having taken so long, but I simply had forgotten about it. Nothing much to say about it: APPROVED Two minor issues: 1) Redundant "Requires:" # rpm -q --requires -p perl-Net-INET6Glue-0.5-2.fc18.noarch.rpm ... perl(IO::Socket::INET6) perl(IO::Socket::INET6) >= 2.54 ... The first R: perl(IO::Socket::INET6) is redundant to the second one. Consider to filter the first one from inside of the spec rsp. to remove the versioned one from the spec. 2) Consider to add these perl-modules to "BR:" perl(Carp) perl(IO::Socket::INET) perl(IO::Socket::INET6) perl(Net::FTP) perl(Socket) perl(strict) perl(warnings) Other reviewers would insist on them, I don't. New Package SCM Request ======================= Package Name: perl-Net-INET6Glue Short Description: Make common modules IPv6 ready by hotpatching them Owners: ktdreyer Branches: f19 f20 el6 Please add InitialCC: perl-sig as described on http://fedoraproject.org/wiki/Packaging:Perl New Package SCM Request ======================= Package Name: perl-Net-INET6Glue Short Description: Make common modules IPv6 ready by hotpatching them Owners: ktdreyer Branches: f19 f20 el6 InitialCC: perl-sig Git done (by process-git-requests). perl-Net-INET6Glue-0.5-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Net-INET6Glue-0.5-3.fc20 perl-Net-INET6Glue-0.5-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Net-INET6Glue-0.5-3.fc19 perl-Net-INET6Glue-0.5-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Net-INET6Glue-0.5-3.el6 Thank you Ralf for the thorough review. In Git I pushed the initial "-2" release, and then a second Git commit for release "-3" with your suggested changes for Requires/BuildRequires. perl-Net-INET6Glue-0.5-3.el6 has been pushed to the Fedora EPEL 6 testing repository. perl-Net-INET6Glue-0.5-3.fc19 has been pushed to the Fedora 19 stable repository. perl-Net-INET6Glue-0.5-3.fc20 has been pushed to the Fedora 20 stable repository. perl-Net-INET6Glue-0.5-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |