Bug 963994

Summary:	Entities aren't being expanded before validation
Product:	[Community] Publican	Reporter:	James Pooton <jpooton>
Component:	publican	Assignee:	Jeff Fearn 🐞 <jfearn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.1	CC:	aigao, jfearn, rlandman
Target Milestone:	3.2
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	4.0.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-19 02:46:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James Pooton 2013-05-17 01:20:58 UTC

Description of problem:

Entities are working fine when used within normal paragraph content, however when trying to use one within Book_Info.xml like:

<productnumber>&PRODUCTVER;</productnumber>

The build will fail with:

Invalid format for version. Value (EMPTY) does not conform to constraint (^[0-9]) at /usr/bin/publican line 713.

Regardless of the value of PRODUCTVER.


Version-Release number of selected component (if applicable):

3.1.5 running under FC18


How reproducible:

Always.


Steps to Reproduce:
1. Create an entity in Book_Info.xml with a valid product number for a value (1.0)
2. Use it as the value for 'productnumber' (an example)
3. Attempt to build the book.
  
Actual results:

Invalid format for version. Value (EMPTY) does not conform to constraint (^[0-9]) at /usr/bin/publican line 713.


Expected results:

Entity value would be substituted and used.


Additional info:

Originated on mailing list at https://www.redhat.com/archives/publican-list/2013-May/msg00000.html

Comment 2 HSS Product Manager 2013-07-18 00:17:36 UTC

HSS-QE has reviewed and declined this request. QE for this bug will be handled by IED.

Comment 3 Jeff Fearn 🐞 2013-07-18 06:24:54 UTC

This requires updating two upstream modules. XML::Catalog & XML::TreeBuilder.

XML::Catalog development has been inactive for some time, so it might take a while to get that sorted out. I've opened an RT ticket with a patch.

XML::TreeBuilder is easier to update, but it does require XML::Catalog to be patched first.

There isn't any code in Publican itself that needs to be changed for this, but we will need to do some decent testing once it's in place just to make sure.

Comment 4 Jeff Fearn 🐞 2013-09-17 06:27:11 UTC

Checked in.

You will need to grab the devel branch sources of two perl modules and update the packages on your system if you wish to test this.

https://github.com/jfearn/perl-XML-Catalog
https://github.com/jfearn/XML-TreeBuilder

Comment 5 Ruediger Landmann 2013-10-11 03:28:09 UTC

Verified on publican-3.9.9-0.fc19.t4.noarch