Bug 964132

Summary: systemd 201-2 broke varnish daemon start
Product: [Fedora] Fedora Reporter: Michał Piotrowski <mkkp4x4>
Component: systemdAssignee: Michal Schmidt <mschmidt>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: johannbg, lnykryn, mschmidt, msekleta, notting, plautrba, systemd-maint, vpavlin, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-201-2.fc18.7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-23 12:22:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Michał Piotrowski 2013-05-17 10:37:28 UTC
Hi,

Description of problem:

I noticed that varnish service doesn't work after systemd update to version 201-2

varnish.service - Varnish a high-perfomance HTTP accelerator
   Loaded: loaded (/usr/lib/systemd/system/varnish.service; enabled)
   Active: failed (Result: exit-code) since czw 2013-05-16 23:12:50 CEST; 1min 2s ago
  Process: 424 ExecStart=/usr/sbin/varnishd -P /var/run/varnish.pid -f $VARNISH_VCL_CONF -a ${VARNISH_LISTEN_ADDRESS}:${VARNISH_LISTEN_PORT} -T ${VARNISH_ADMIN_LISTEN_ADDRESS}:${VARNISH_ADMIN_LISTEN_PORT} -t $VARNISH_TTL -w ${VARNISH_MIN_THREADS},${VARNISH_MAX_THREADS},${VARNISH_THREAD_TIMEOUT} -u $VARNISH_USER -g $VARNISH_GROUP -S $VARNISH_SECRET_FILE -s $VARNISH_STORAGE $DAEMON_OPTS (code=exited, status=1/FAILURE)

maj 16 23:12:50 ozzy.pl varnishd[424]: usage: varnishd [options]
maj 16 23:12:50 ozzy.pl varnishd[424]: -a address:port              # HTTP listen address and port
maj 16 23:12:50 ozzy.pl varnishd[424]: -b address:port              # backend address and port
maj 16 23:12:50 ozzy.pl varnishd[424]: #    -b <hostname_or_IP>
maj 16 23:12:50 ozzy.pl varnishd[424]: #    -b '<hostname_or_IP>:<port_or_service>'
maj 16 23:12:50 ozzy.pl varnishd[424]: -C                           # print VCL code compiled to C language
maj 16 23:12:50 ozzy.pl varnishd[424]: -d                           # debug
maj 16 23:12:50 ozzy.pl varnishd[424]: -f file                      # VCL script
maj 16 23:12:50 ozzy.pl varnishd[424]: -F                           # Run in foreground
maj 16 23:12:50 ozzy.pl varnishd[424]: -h kind[,hashoptions]        # Hash specification
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -h critbit [default]
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -h simple_list
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -h classic
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -h classic,<buckets>
maj 16 23:12:50 ozzy.pl varnishd[424]: -i identity                  # Identity of varnish instance
maj 16 23:12:50 ozzy.pl varnishd[424]: -l shl,free,fill             # Size of shared memory file
maj 16 23:12:50 ozzy.pl varnishd[424]: #   shl: space for SHL records [80m]
maj 16 23:12:50 ozzy.pl varnishd[424]: #   free: space for other allocations [1m]
maj 16 23:12:50 ozzy.pl varnishd[424]: #   fill: prefill new file [+]
maj 16 23:12:50 ozzy.pl varnishd[424]: -M address:port              # Reverse CLI destination.
maj 16 23:12:50 ozzy.pl varnishd[424]: -n dir                       # varnishd working directory
maj 16 23:12:50 ozzy.pl varnishd[424]: -P file                      # PID file
maj 16 23:12:50 ozzy.pl varnishd[424]: -p param=value               # set parameter
maj 16 23:12:50 ozzy.pl varnishd[424]: -s kind[,storageoptions]     # Backend storage specification
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s malloc
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s file  [default: use /tmp]
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s file,<dir_or_file>
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s file,<dir_or_file>,<size>
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s persist{experimenta}
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -s file,<dir_or_file>,<size>,<granularity>
maj 16 23:12:50 ozzy.pl varnishd[424]: -t                           # Default TTL
maj 16 23:12:50 ozzy.pl varnishd[424]: -S secret-file               # Secret file for CLI authentication
maj 16 23:12:50 ozzy.pl varnishd[424]: -T address:port              # Telnet listen address and port
maj 16 23:12:50 ozzy.pl varnishd[424]: -V                           # version
maj 16 23:12:50 ozzy.pl varnishd[424]: -w int[,int[,int]]           # Number of worker threads
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -w <fixed_count>
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -w min,max
maj 16 23:12:50 ozzy.pl varnishd[424]: #   -w min,max,timeout [default: -w2,500,300]
maj 16 23:12:50 ozzy.pl varnishd[424]: -u user                      # Priviledge separation user id
maj 16 23:12:50 ozzy.pl systemd[1]: varnish.service: control process exited, code=exited status=1
maj 16 23:12:50 ozzy.pl systemd[1]: Failed to start Varnish a high-perfomance HTTP accelerator.
maj 16 23:12:50 ozzy.pl systemd[1]: Unit varnish.service entered failed state.

I downgraded systemd to version 195-15 and varnish works fine again.

Comment 1 Michal Schmidt 2013-05-17 11:21:41 UTC
OK, I can reproduce this. It turns out these two lines in the default /etc/varnish/varnish.params have trailing whitespace, which gets included in the ExecStart command line:

VARNISH_MIN_THREADS=5
VARNISH_MAX_THREADS=1000

As a workaround, remove the trailing whitespace.

Comment 2 Michal Schmidt 2013-05-17 11:31:21 UTC
I cannot reproduce this in F19. Looking for a patch to cherry-pick to F18...

Comment 3 Fedora Update System 2013-05-17 12:35:05 UTC
systemd-201-2.fc18.7 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/systemd-201-2.fc18.7

Comment 4 Michał Piotrowski 2013-05-17 12:42:42 UTC
Works fine. Thank you very much!

Best regards,
Michal

Comment 5 Fedora Update System 2013-05-19 02:45:02 UTC
Package systemd-201-2.fc18.7:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-201-2.fc18.7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-8598/systemd-201-2.fc18.7
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-05-23 12:22:15 UTC
systemd-201-2.fc18.7 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.