Bug 965459

Summary: pmount package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: pmountAssignee: Richard Shaw <hobbes1069>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: agk, bressers, hobbes1069, jpmahowald, ktdreyer, pertusus, vvitek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pmount-0.9.23-4.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-30 02:54:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-05-21 09:35:32 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package has suid binaries...".

However, currently pmount is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

pmount-0.9.23-3.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py pmount-0.9.23-3.fc19.x86_64.rpm
pmount,pmount-0.9.23-3.fc19.x86_64.rpm,/usr/bin/pmount,mode=0104755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
pmount,pmount-0.9.23-3.fc19.x86_64.rpm,/usr/bin/pumount,mode=0104755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None

Comment 1 Fedora Update System 2013-05-21 17:35:41 UTC
pmount-0.9.23-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/pmount-0.9.23-4.fc18

Comment 2 Fedora Update System 2013-05-21 17:35:54 UTC
pmount-0.9.23-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/pmount-0.9.23-4.fc19

Comment 3 Fedora Update System 2013-05-21 17:36:05 UTC
pmount-0.9.23-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/pmount-0.9.23-4.fc17

Comment 4 Fedora Update System 2013-05-22 01:24:08 UTC
Package pmount-0.9.23-4.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing pmount-0.9.23-4.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-8789/pmount-0.9.23-4.fc17
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-05-30 02:54:36 UTC
pmount-0.9.23-4.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2013-05-30 02:58:00 UTC
pmount-0.9.23-4.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2013-06-06 02:23:08 UTC
pmount-0.9.23-4.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.