Bug 965461

Summary: pwauth package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: pwauthAssignee: Philip Prindeville <philipp>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, philipp, pwouters, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pwauth-2.3.10-5.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-13 06:51:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-05-21 09:37:29 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package has suid binaries...".

However, currently pwauth is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

pwauth-2.3.10-4.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py pwauth-2.3.10-4.fc19.x86_64.rpm
pwauth,pwauth-2.3.10-4.fc19.x86_64.rpm,/usr/bin/pwauth,mode=0104750,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None

Comment 1 Dhiru Kholia 2013-06-03 06:17:59 UTC
Hi,

Is there any progress on this?

Do you want me to send a patch for this?

Comment 2 Fedora Update System 2013-06-03 16:57:03 UTC
pwauth-2.3.10-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/pwauth-2.3.10-5.fc18

Comment 3 Fedora Update System 2013-06-03 16:58:25 UTC
pwauth-2.3.10-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/pwauth-2.3.10-5.fc17

Comment 4 Fedora Update System 2013-06-03 16:59:15 UTC
pwauth-2.3.10-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/pwauth-2.3.10-5.fc19

Comment 5 Fedora Update System 2013-06-03 16:59:57 UTC
pwauth-2.3.10-5.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pwauth-2.3.10-5.el6

Comment 6 Philip Prindeville 2013-06-03 18:06:39 UTC
No, I had already patched it and done a build. Didn't get around to flagging the build as an update candidate, but just took care of that now.

Comment 7 Fedora Update System 2013-06-03 19:29:41 UTC
Package pwauth-2.3.10-5.el6:
* should fix your issue,
* was pushed to the Fedora EPEL 6 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing pwauth-2.3.10-5.el6'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-6066/pwauth-2.3.10-5.el6
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2013-06-13 06:51:02 UTC
pwauth-2.3.10-5.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2013-06-14 02:30:54 UTC
pwauth-2.3.10-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2013-06-14 02:33:11 UTC
pwauth-2.3.10-5.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2013-06-18 20:43:42 UTC
pwauth-2.3.10-5.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.