Bug 965467

Summary: uucp package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: uucpAssignee: Nils Philippsen <nphilipp>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, dhiru, nphilipp, ovasik, praiskup
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: uucp-1.07-37.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-24 10:57:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-05-21 09:43:56 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package has suid binaries...".

However, currently uucp is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

uucp-1.07-34.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py uucp-1.07-34.fc19.x86_64.rpm
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/cu,mode=0106555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uucp,mode=0104555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uulog,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uuname,mode=0106555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uupick,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uustat,mode=0104555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/bin/uux,mode=0104555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/sbin/uuchk,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/sbin/uucico,mode=0106555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/sbin/uuconv,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
uucp,uucp-1.07-34.fc19.x86_64.rpm,/usr/sbin/uuxqt,mode=0106555,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None

Comment 1 Nils Philippsen 2013-05-21 15:09:31 UTC
Bugzilla's had a hickup.

I've submitted updates for Fedora 17 through 19 here:

https://admin.fedoraproject.org/updates/uucp-1.07-37.fc17
https://admin.fedoraproject.org/updates/uucp-1.07-37.fc18
https://admin.fedoraproject.org/updates/uucp-1.07-37.fc19

Comment 2 Nils Philippsen 2014-02-24 10:57:10 UTC
Long since fixed.