Bug 965505

Summary: ecryptfs-utils package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: ecryptfs-utilsAssignee: Michal Hlavinka <mhlavink>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, esandeen, mhlavink
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ecryptfs-utils-103-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-05 03:21:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-05-21 10:13:23 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package has suid binaries...".

However, currently ecryptfs-utils is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

ecryptfs-utils-103-1.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py ecryptfs-utils-103-1.fc19.x86_64.rpm
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/sbin/mount.ecryptfs,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/sbin/mount.ecryptfs_private,mode=0104750,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/sbin/umount.ecryptfs,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-add-passphrase,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-generate-tpm-key,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-insert-wrapped-passphrase-into-keyring,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-manager,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-rewrap-passphrase,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-stat,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-unwrap-passphrase,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfs-wrap-passphrase,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
ecryptfs-utils,ecryptfs-utils-103-1.fc19.x86_64.rpm,/usr/bin/ecryptfsd,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
Comment 1 Fedora Update System 2013-05-24 12:28:49 UTC 
ecryptfs-utils-103-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ecryptfs-utils-103-2.fc19
Comment 2 Fedora Update System 2013-05-24 19:48:29 UTC 
Package ecryptfs-utils-103-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ecryptfs-utils-103-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-9090/ecryptfs-utils-103-2.fc19
then log in and leave karma (feedback).
Comment 3 Fedora Update System 2013-06-05 03:21:37 UTC 
ecryptfs-utils-103-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.