Bug 965513

Summary: torque package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: torqueAssignee: David Brown <david.brown>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: bressers, dhiru, fotis, karlthered
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: torque-4.2.10-3.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-30 15:42:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-05-21 10:17:44 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package has suid binaries...".

However, currently torque is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

torque-client-3.0.4-1.fc17.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py torque-client-3.0.4-1.fc17.x86_64.rpm
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/chk_tree,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/hostn,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/pbs_tclsh,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/pbsdsh,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-local
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/pbsnodes,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/printjob,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/printserverdb,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/printtracking,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qalter-torque,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qchkpt,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qdel-torque,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qdisable,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qenable,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qgpumode,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qgpureset,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qhold-torque,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qmgr,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qmove,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qmsg,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qorder,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qrerun,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qrls-torque,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qrun,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qselect-torque,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qsig,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qstart,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qstat-torque,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qstop,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qsub-torque,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-local
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/qterm,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=NA,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/bin/tracejob,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/sbin/momctl,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/sbin/pbs_demux,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-local
torque-client,torque-client-3.0.4-1.fc17.x86_64.rpm,/usr/sbin/pbs_iff,mode=0104755,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
Comment 1 Dhiru Kholia 2013-05-21 10:20:55 UTC 
*** Bug 965514 has been marked as a duplicate of this bug. ***
Comment 2 Orion Poplawski 2013-08-17 03:01:40 UTC 
To use this in your spec, add:

%global _hardened_build 1
Comment 4 Fedora End Of Life 2015-01-09 22:07:41 UTC 
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 5 Jaroslav Reznik 2015-03-03 16:53:03 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22
Comment 6 Fedora Admin XMLRPC Client 2015-04-21 15:11:05 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 7 David Brown 2015-05-03 06:21:18 UTC 
$ ./scanner.py ~/Downloads/torque-client-4.2.10-2.fc23.x86_64.rpm 
Analyzing /home/dmlb2000/Downloads/torque-client-4.2.10-2.fc23.x86_64.rpm ...
torque-client,torque-client-4.2.10-2.fc23.x86_64.rpm,/usr/bin/chk_tree,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None,TEMPPATHS=None,DEPS=libtorque.so.2$libmunge.so.2$libxml2.so.2$libz.so.1$libdl.so.2$libcrypto.so.10$libssl.so.10$libpthread.so.0$librt.so.1$libstdc++.so.6$libm.so.6$libgcc_s.so.1$libc.so.6
torque-client,torque-client-4.2.10-2.fc23.x86_64.rpm,/usr/bin/hostn,mode=0100755,NX=Enabled,CANARY=Disabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Partial$memcpy,CATEGORY=network-ip,TEMPPATHS=None,DEPS=libtorque.so.2$libmunge.so.2$libxml2.so.2$libz.so.1$libdl.so.2$libcrypto.so.10$libssl.so.10$libpthread.so.0$librt.so.1$libstdc++.so.6$libm.so.6$libgcc_s.so.1$libc.so.6
torque-client,torque-client-4.2.10-2.fc23.x86_64.rpm,/usr/bin/pbs_tclsh,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Partial$strncpy,CATEGORY=None,TEMPPATHS=None,DEPS=libtorque.so.2$libmunge.so.2$libtcl8.6.so$libxml2.so.2$libz.so.1$libdl.so.2$libcrypto.so.10$libssl.so.10$libpthread.so.0$librt.so.1$libstdc++.so.6$libm.so.6$libgcc_s.so.1$libc.so.6
torque-client,torque-client-4.2.10-2.fc23.x86_64.rpm,/usr/bin/pbsdsh,mode=0100755,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Partial$strncpy$memcpy$fgets,CATEGORY=network-local,TEMPPATHS=None,DEPS=libtorque.so.2$libmunge.so.2$libxml2.so.2$libz.so.1$libdl.so.2$libcrypto.so.10$libssl.so.10$libpthread.so.0$librt.so.1$libstdc++.so.6$libm.so.6$libgcc_s.so.1$libc.so.6
...

Looks like this is still an issue in latest fedora rawhide I've got building... will take a look at this soon.  Thanks.
Comment 8 David Brown 2015-05-03 06:22:47 UTC 
Or is the output good output?

[dmlb2000@uber-gamer checksec]$ ./scanner.py ~/Downloads/torque-client-4.2.10-2.fc23.x86_64.rpm | grep PIE=Disabled
Analyzing /home/dmlb2000/Downloads/torque-client-4.2.10-2.fc23.x86_64.rpm ...
[dmlb2000@uber-gamer checksec]$
Comment 9 Dhiru Kholia 2015-05-03 08:13:48 UTC 
Seems good to me (I haven't run the scanner.py myself) :-)
Comment 10 Fedora Update System 2015-05-19 19:46:43 UTC 
torque-4.2.10-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.el5
Comment 11 Fedora Update System 2015-05-19 19:47:48 UTC 
torque-4.2.10-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.el6
Comment 12 Fedora Update System 2015-05-19 19:48:39 UTC 
torque-4.2.10-3.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.el7
Comment 13 Fedora Update System 2015-05-19 19:49:18 UTC 
torque-4.2.10-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.fc21
Comment 14 Fedora Update System 2015-05-19 19:55:37 UTC 
torque-4.2.10-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.fc20
Comment 15 Fedora Update System 2015-05-19 19:56:14 UTC 
torque-4.2.10-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/torque-4.2.10-3.fc22
Comment 16 Fedora Update System 2015-05-20 02:53:31 UTC 
Package torque-4.2.10-3.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing torque-4.2.10-3.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-8544/torque-4.2.10-3.fc22
then log in and leave karma (feedback).
Comment 17 Fedora Update System 2015-05-30 15:42:27 UTC 
torque-4.2.10-3.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 18 Fedora Update System 2015-05-30 15:45:05 UTC 
torque-4.2.10-3.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2015-05-30 15:54:23 UTC 
torque-4.2.10-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2015-06-04 15:55:59 UTC 
torque-4.2.10-3.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 21 Fedora Update System 2015-06-04 15:56:29 UTC 
torque-4.2.10-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 22 Fedora Update System 2015-06-04 15:57:08 UTC 
torque-4.2.10-3.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.