Bug 965770

Summary: RESCAN DISKS: do not interrupt rescanning when Esc is pressed
Product: [Fedora] Fedora Reporter: Jan Stodola <jstodola>
Component: anacondaAssignee: Chris Lumens <clumens>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 19CC: dshea, g.kaviyarasu, jonathan, mkolman, rtguille, sbueno, vanmeeuwen+fedora
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-19.31-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-29 19:01:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 920667    
Attachments:
Description Flags
screenshot none

Description Jan Stodola 2013-05-21 16:53:45 UTC 
Description of problem:
There is no button enabled to stop rescanning disks, which is available from the Manual Partitioning spoke.

Version-Release number of selected component (if applicable):
Fedora-19-Beta-RC2
anaconda-19.24-1

How reproducible:
always

Steps to Reproduce:
1. start graphical installation
2. proceed to the Manual Partitioning spoke
3. click on "Reload storage configuration from disk."
4. click "Rescan Disks"
5. note that no button is enabled to stop the rescanning (see attached screenshot)
6. press the Esc key while the rescan is still running

Actual results:
RESCAN DISKS dialog closes after pressing the Esc key, but it is not possible to stop it using mouse clicking on some button.

Expected results:
It is possible to stop rescanning disks by clicking on some button (Cancel for example) as well as pressing the Esc key.
Comment 1 Jan Stodola 2013-05-21 16:54:37 UTC 
Created attachment 751319 [details]
screenshot
Comment 2 Reartes Guillermo 2013-05-21 18:54:30 UTC 
But should "Rescan Disks" be atomic/transaction?

Either you have the current values or you have the values you asked to re-read from disk. 

Is an interrupted disk rescan for anaconda something "in between"?
Comment 3 Brian Lane 2013-05-22 00:50:12 UTC 
Once a rescan is started you cannot stop it. Doing so would leave the system in an inconsistent state.
Comment 4 Jan Stodola 2013-05-22 07:23:24 UTC 
In that case, you should not close the dialog window while rescanning is in progress and the Esc key is pressed. Reopening.
Comment 5 Chris Lumens 2013-06-24 14:12:56 UTC 
There's bound to be more dialogs that could use this treatment, but now we've got a function to make it easy.
Comment 6 Jan Stodola 2013-09-26 10:44:53 UTC 
Retested with anaconda-20.18-1 (F20-Alpha-RC4) and it is not possible to interrupt disk rescanning by pressing the Esc key and no button is available to stop the rescan.

Moving to VERIFIED.