Bug 965987

Summary: rm is blocked on the fuse mount while trying to remove directories and files from the FUSE and NFS mount simultaneously
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: replicateAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: amarts, gluster-bugs, rhinduja, rhs-bugs, vbellur
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 956034 Environment:
Last Closed: 2013-07-24 17:54:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 956034    
Bug Blocks:    

Comment 1 Anand Avati 2013-05-22 09:02:21 UTC 
REVIEW: http://review.gluster.org/5062 (cluster/afr: Avoid order mismatch in blocking entrylks) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
Comment 2 Anand Avati 2013-05-22 09:11:37 UTC 
REVIEW: http://review.gluster.org/5063 (cluster/afr: Avoid order mismatch in blocking entrylks) posted (#1) for review on release-3.4 by Pranith Kumar Karampuri (pkarampu)
Comment 3 Anand Avati 2013-06-05 12:23:27 UTC 
COMMIT: http://review.gluster.org/5062 committed in master by Vijay Bellur (vbellur) 
------
commit 7413ed951f9b5615dc63f94a8e702cb8f6a8bd98
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 22 11:59:27 2013 +0530

    cluster/afr: Avoid order mismatch in blocking entrylks
    
    Problem:
    When taking blocking entrylks, afr orders the entrylks based on
    uuid_compare of gfids of parent dirs, if they are equal then it orders
    them based on the basenames. While this approach works fine, the
    implementation assumes loc->gfids to be populated at the time of
    the comparison, but loc may have gfid in loc->inode->gfid instead
    of loc->gfid which was leading to order mismatches and dead-locks.
    
    Fix:
    Implemented loc_gfid which gives gfid by checking both loc->gfid,
    loc->inode->gfid. Used this for ordering the blocking entrylks.
    
    Change-Id: Ib0db36bbaf0df09fa87c3c3bb6a834db74fc2154
    BUG: 965987
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/5062
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Jeff Darcy <jdarcy>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 4 Anand Avati 2013-06-06 18:54:12 UTC 
COMMIT: http://review.gluster.org/5063 committed in release-3.4 by Vijay Bellur (vbellur) 
------
commit b7ac8e415961c9e203ed3f56b4115b7eb215ab94
Author: Pranith Kumar K <pkarampu>
Date:   Wed May 22 14:40:22 2013 +0530

    cluster/afr: Avoid order mismatch in blocking entrylks
    
    Problem:
    When taking blocking entrylks, afr orders the entrylks based on
    uuid_compare of gfids of parent dirs, if they are equal then it orders
    them based on the basenames. While this approach works fine, the
    implementation assumes loc->gfids to be populated at the time of
    the comparison, but loc may have gfid in loc->inode->gfid instead
    of loc->gfid which was leading to order mismatches and dead-locks.
    
    Fix:
    Implemented loc_gfid which gives gfid by checking both loc->gfid,
    loc->inode->gfid. Used this for ordering the blocking entrylks.
    
    Change-Id: I2743fcaff3d670fbeb6b8e0a496f106a3585dde1
    BUG: 965987
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/5063
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>