Bug 966143
Summary: | Many duplicate files lead to unreasonable increase of size of a publican installation, Publican should share common files | ||
---|---|---|---|
Product: | [Community] Publican | Reporter: | Raphaël Hertzog <raphael> |
Component: | publican | Assignee: | Jeff Fearn 🐞 <jfearn> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Petr Bokoc <pbokoc> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.1 | CC: | aigao, jfearn, pbokoc, rlandman |
Target Milestone: | 3.2 | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Fixed In Version: | 3.2.0 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-08-09 04:47:12 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Raphaël Hertzog
2013-05-22 15:08:19 UTC
dev note: there is no need for the content in /usr/share to be duplicated per language. The build process already copies the source language content and then copies the translation language content over the top. This is just a flat out bug. (In reply to Jeff Fearn from comment #2) > dev note: there is no need for the content in /usr/share to be duplicated > per language. The build process already copies the source language content > and then copies the translation language content over the top. > > This is just a flat out bug. Actually I am wrong. I was thinking this was in /usr/share/publican but it's in /usr/share/doc/publican. /usr/share/doc/publican contains static HTML. You have no guarantee at this point that any other language, or any other output format, is installed, so you have to assume you need all the content for each format in each language. You will note that /usr/share/publican/CommonContent does not have this duplication, because that is source and the logic in #1 is used during the build phase. This would be a very intrusive change to make on the normal output and would probably make more sense to do as a specific output format for this use case. No, no, you were right. /usr/share/publican contains most of the problematic duplication, the duplication in /usr/share/doc/ is expected, the documentation must be stand-alone. dpkg -L publican | sed -ne 's|/usr/share/publican/Common_Content/.*/||p' | sort | uniq -c | sort -nr|head 107 40.svg 107 40.png 107 39.svg 107 39.png 107 38.svg 107 38.png 107 37.svg 107 37.png 107 36.svg 107 36.png ah then it's a bug in the brand publishing code. Not so hard to fix. HSS-QE has reviewed and declined this request. QE for this bug will be handled by IED. Stopped brand install from duplicating css, images, & scripts sources. To ssh://git.fedorahosted.org/git/publican.git b85fec3..4bd6cc7 HEAD -> devel $ rpm -qi publican | grep Size Size : 3093902 Publican now seems to be vastly reduced in size. Verified in publican-3.1.5-0.fc17.t62.noarch. The fix for this bug has been shipped in publican 3.2.0 |