Bug 966790

Summary:	App is not unidled consistently when primary cartridge is started by user
Product:	OpenShift Online	Reporter:	Dan Mace <dmace>
Component:	Containers	Assignee:	Dan Mace <dmace>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	chunchen, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-11 04:10:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1232907, 1264216

Description Dan Mace 2013-05-24 01:29:37 UTC

Description of problem:

Idled v2 apps are not always unidled when started by the user as a result of a build. For instance, when using Jenkins, an idled app will be started but not unidled.

Version-Release number of selected component (if applicable):


How reproducible:

Create an app with Jenkins enabled. Idle the app gear. Build the app.

Steps to Reproduce:
1.
2.
3.

Actual results:

The app will be started and in the 'started' state, but the idler entry will still exist in /var/lib/openshift/.http.d/idler.txt.

Expected results:

The app to be started, in the 'started' state, and removed from the idler list.

Additional info:

Comment 2 Dan Mace 2013-05-24 13:51:03 UTC

Resolved by https://github.com/openshift/origin-server/pull/2629.

In addition testing building an idled application with Jenkins, please also test building idled applications which do not use Jenkins; in both cases, the app should be both started and unidled (according to /var/lib/openshift/.http.d/idler.txt).

Comment 3 openshift-github-bot 2013-05-24 22:51:46 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/878d68fba4f901b157a25d26a9afd958589dd642
Bug 966790: Handle unidling consistently in the cart model

Comment 4 chunchen 2013-05-27 10:37:38 UTC

It's fixed, verified on devenv_3277,please refer to the following results:

1. for app with jenkins
1) Create app with jenkins
rhc app create cpython60 python-2.6 --enable-jenkins
2) Idle this app
oo-idler -u 51a331867e99de7aa2000001
3) Show the status of this app and check idler.txt
[root@F18-CCY test]# rhc app show cpython60 --gears 
ID                       State Cartridges                    Size  SSH URL
------------------------ ----- ----------------------------- ----- ------------------------------------------------------
51a331867e99de7aa2000001 idle  python-2.6 jenkins-client-1.4 small 51a331867e99de7aa2000001.rhcloud.com

[root@ip-10-165-39-215 .httpd.d]# cat /var/lib/openshift/.httpd.d/idler.txt |grep 51a331867e99de7aa2000001
cpython60-cdm.dev.rhcloud.com 51a331867e99de7aa2000001
[root@ip-10-165-39-215 .httpd.d]#
4) make some changes in this app local repo and git push
echo "test text!" > t1.txt
git add .; git commit -amp; git push
5) Show the status of this app and check idler.txt
[root@F18-CCY cpython60]# rhc app show cpython60 --gears
ID                       State   Cartridges                    Size  SSH URL
------------------------ ------- ----------------------------- ----- ------------------------------------------------------
51a331867e99de7aa2000001 started python-2.6 jenkins-client-1.4 small 51a331867e99de7aa2000001.rhcloud.com

[root@ip-10-165-39-215 .httpd.d]# cat /var/lib/openshift/.httpd.d/idler.txt |grep 51a331867e99de7aa2000001
[root@ip-10-165-39-215 .httpd.d]#    

    
2. for app without jenkins
1) Create app without jenkins
rhc app create cruby80 ruby-1.8
2) Idle this app
oo-idler -u 948511341651594496180224
3) Show the status of this app and check idler.txt
[root@F18-CCY test]# rhc app show cruby80 --gears 
ID                       State Cartridges Size  SSH URL
------------------------ ----- ---------- ----- ----------------------------------------------------
948511341651594496180224 idle  ruby-1.8   small 948511341651594496180224.rhcloud.com

[root@ip-10-165-39-215 .httpd.d]# cat /var/lib/openshift/.httpd.d/idler.txt |grep 948511341651594496180224
cruby80-cdm.dev.rhcloud.com 948511341651594496180224
[root@ip-10-165-39-215 .httpd.d]#
4) make some changes in this app local repo and git push
echo "test text!" > t.txt
git add .; git commit -amp; git push
5) Show the status of this app and check idler.txt
[root@F18-CCY cruby80]# rhc app show --gears
ID                       State   Cartridges Size  SSH URL
------------------------ ------- ---------- ----- ----------------------------------------------------
948511341651594496180224 started ruby-1.8   small 948511341651594496180224.rhcloud.com

[root@ip-10-165-39-215 .httpd.d]# cat /var/lib/openshift/.httpd.d/idler.txt |grep 948511341651594496180224
[root@ip-10-165-39-215 .httpd.d]#