Bug 967308

Summary:	allow swift object versioning by default
Product:	Red Hat OpenStack	Reporter:	Attila Fazekas <afazekas>
Component:	openstack-packstack	Assignee:	Francesco Vollero <fvollero>
Status:	CLOSED ERRATA	QA Contact:	Attila Darazs <adarazs>
Severity:	low	Docs Contact:
Priority:	low
Version:	3.0	CC:	adarazs, aortega, ddomingo, derekh, fvollero, jkt, mmagr, slong
Target Milestone:	z2	Keywords:	Triaged, ZStream
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-packstack-2013.2.1-0.25.dev987.el6ost	Doc Type:	Bug Fix
Doc Text:	Previously, swift's object versioning was disabled by default. With this update, this feature is now enabled in the default configuration file ('allow_versions "true"' in /etc/swift/container-server.conf).	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-03-04 19:12:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Attila Fazekas 2013-05-26 12:51:38 UTC

Important swift feature not working by the default install:
http://docs.openstack.org/developer/swift/overview_object_versioning.html

The object versioning should be enabled by default.

/etc/swift/container-server.conf:
[app:container-server] 
  allow_versions  "true"

Comment 2 Francesco Vollero 2013-07-18 11:05:42 UTC

FYI the object versioning is disabled by default in Swift.
While I agree with you that puppet-swift should be able to activate/deactivate the versioning, I am not entirely sure that everyone want to have it enabled by default.
So, my thought here is to let the sysadmin to decide if they want to have it or not enabled.

Comment 5 Attila Darazs 2014-02-20 16:43:34 UTC

The default is false now, as can be seen at the linked change[1], so it didn't fix the bug, and because of this, the Doc Text is incorrect as well. Please correct the puppet module to have a default true, or close the bug as WONTFIX (though we need this value to be true for Tempest tests).

[1] https://review.openstack.org/#/c/37493/4/manifests/storage/server.pp

Comment 8 Francesco Vollero 2014-02-22 12:46:16 UTC

Attila, the patch was for puppet-swift upstream and not for packstack itself.
During the discussion on irc in July 2013, I got as feedback from the core guys that would be better, as I wrote in my comment, that the devop had to decide for himself if to set or not and that the default value have to be the same as it is on the documentation/current config file, in our case false by default.
This mean that you should have checked the packstack puppet modules[1] and not refer to that review.

[1] https://github.com/stackforge/packstack/tree/master/packstack/puppet/templates

Comment 9 Attila Darazs 2014-02-24 14:48:29 UTC

This bug is for packstack. It's about enabling the versioning by default. Currently it's not the default. It's not even exposed to packstack through an option/answer file, so I don't see how this bug is fixed.

I understand that the option to change this was added to the *puppet* module of swift, it's still completely unavailable to anybody who doesn't specifically know about it and is using the puppet modules directly.

Regarding the correct/incorrect link: Francesco, you linked the master branch of packstack. The Havana branch is using subrepositories, which includes the puppet-swift repo directly, thus the merged change is the relevant one that is included currently in the stable Havana packages.

To reiterate: to close this bug successfully either the default should be changed or at least the possibility to change the option should be added to packstack's command line + answer file.

A.

Comment 13 Francesco Vollero 2014-02-25 22:11:40 UTC

The bug, now is fixed.

Comment 14 Attila Darazs 2014-02-26 11:31:42 UTC

Now it's fixed... in the master branch. Is this going to get included in the Havana packstack package?

Comment 17 Attila Darazs 2014-03-03 12:10:32 UTC

After installing with packstack, the value is now correct. Verified.

[root@node ~]# grep allow_versions /etc/swift/container-server.conf
allow_versions = true

Comment 19 errata-xmlrpc 2014-03-04 19:12:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2014-0233.html