Bug 967332
| Summary: | Review Request: rubygem-chardet - Character encoding auto-detection in Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedoraparked, hhorak, package-review, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-01-04 08:59:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
fedoraparked
2013-05-26 17:23:44 UTC
Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-chardet/mock rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. I will take it for a review. From your spec file: ``` # URL: http://blog.vava.cn/ # This URL is mentioned in the Gem but doesn't open URL: https://github.com/janx/chardet ``` The original chardet gem is actually hosted on RubyForge[1] and maintained by Hui Zheng. The release is from 2006 and I don't see any new development or updates here. The URL you are mentioning belongs to chardet2[2], which is pretty new, it's based on chardet and seems to be maintained. Apart from that I am unsure whether is chardet Ruby 2.0 ready or not, since I can see that there is a commit regarding Ruby 2.0 compatibility in chardet2[3]. Fedora 19 will use Ruby 2.0 as a default and it would be pointless to package a sort-of dead project that wasn't tested on Ruby 2.0 (although backporting of the above mentioned commit could solve it). Is there a reason to package this gem? Wouldn't be better to bring chardet2 to Fedora? [1] http://rubyforge.org/projects/chardet/ [2] https://rubygems.org/gems/chardet2 [3] https://github.com/janx/chardet2/commit/32cc6147b2e519eb3bd777e0bc854b5bfac11ecd I discussed this with the maintainer yesterday: https://github.com/janx/chardet2/issues/9 The change in URL and the repo name was done less than 10 days ago, where as I packaged the Gem quite some time ago. After a discussion with vondruch, I packaged this Gem again as chardet2, and it worked with no major changes made to this specfile. https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-chardet2/rubygem-chardet2.spec This runs fine on mock as well. I was thinking of removing this request and filing another one for chardet2, but I was going to discuss this with the GitLab guys before doing that. Nevermind, though. Anuj, as I see the upstream ticket, they are not really helpful unfortunately :/ They don't mind to propose even yet another fork, which is exactly the opposite of what we want. Could you please try to contact the original chardet author and try it the other way around? I.e. the original author will revive the development, or give them commit access and allow them to push new gems to rubygems.org. Thank you. Closing this stalled review. |