Bug 967393

Summary: compilation error - qemu_migration.c - current git
Product: [Community] Virtualization Tools Reporter: ingram.julian
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: dyasny, jdenemar
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-27 08:45:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ingram.julian 2013-05-27 02:50:46 UTC
Description of problem:

compilation error - current git - libvirt_driver_qemu_impl_la-qemu_migration.lo

Version-Release number of selected component (if applicable):

git v1.0.5-385-g2697c8a

How reproducible:

Consistent.

Steps to Reproduce:

On a fresh Debian install;

apt-get -y install build-essential \
                libtool \
                autoconf \
                automake \
                autopoint \
                pkg-config \
                python-dev \
                libxml2-utils \
                libxml2-dev \
                libdevmapper-dev \
                libnl-dev \
                xsltproc \
                gettext \
                w3c-dtd-xhtml

cd /usr/local/src/
git clone git://libvirt.org/libvirt.git
cd libvirt*
./autogen.sh
make

Actual results:

  CC     libvirt_driver_qemu_impl_la-qemu_migration.lo
qemu/qemu_migration.c: In function 'qemuMigrationCookieGraphicsAlloc':
qemu/qemu_migration.c:320:9: error: label 'error' used but not defined
qemu/qemu_migration.c: At top level:
cc1: error: unrecognized command line option "-Wno-unused-command-line-argument" [-Werror]
cc1: all warnings being treated as errors
make[3]: *** [libvirt_driver_qemu_impl_la-qemu_migration.lo] Error 1
make[3]: Leaving directory `/usr/local/src/libvirt/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr/local/src/libvirt/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/src/libvirt'
make: *** [all] Error 2


Expected results:

CC     libvirt_driver_qemu_impl_la-qemu_migration.lo
CC     (...)

Additional info:

Apologies if I'm doing something to mess it up

Comment 1 Jiri Denemark 2013-05-27 08:45:16 UTC
Fixed by

commit c6f2523fb168e39232039766aa0287b5fbb77b5f
Author: Jiri Denemark <jdenemar>
Date:   Mon May 27 10:19:36 2013 +0200

    qemu: Fix build without gnutls
    
    "error" label in qemuMigrationCookieGraphicsAlloc is now used
    unconditionally thanks to VIR_STRDUP.