Bug 967403

python-devel in BR is deprecated, use python2-devel:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

Actually you are packaging a fully versioned tarball, but in particular you are using a VCS checkout. Somewhat strange that a developer a kind of "rolling release" this way... The release tag has to reflect this issue. See for more information (and to get a proper upgrade path):
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages


Just ran rpmlint on your spec:

rpmlint -i -v *
python-tvrage.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 9)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

python-tvrage.spec: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.


There are some testing scripts in the "tests" subfolder, is it possible to run them (in a %check section)?

(In reply to Mario Blättermann from comment #1)
> python-devel in BR is deprecated, use python2-devel:
> https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

Fixed.

> Actually you are packaging a fully versioned tarball, but in particular you
> are using a VCS checkout. Somewhat strange that a developer a kind of
> "rolling release" this way... The release tag has to reflect this issue. See
> for more information (and to get a proper upgrade path):
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

Is it a problem? I don't think so, the author has tagged it as 0.4.1 so I think we don't need to care about it's from when and where.

> Just ran rpmlint on your spec:
> 
> rpmlint -i -v *
> python-tvrage.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab:
> line 9)

Fixed.

> python-tvrage.spec: I: checking-url
> https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.
> tar.gz (timeout 10 seconds)

Your internet problem.

> There are some testing scripts in the "tests" subfolder, is it possible to
> run them (in a %check section)?

Fixed.

NEW Spec URL: http://cicku.me/python-tvrage.spec
NEW SRPM URL: http://cicku.me/python-tvrage-0.4.1-2.fc20.src.rpm

(In reply to Christopher Meng from comment #2)
> 
> > python-tvrage.spec: I: checking-url
> > https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.
> > tar.gz (timeout 10 seconds)
> 
> Your internet problem.
> 
Actually no problem at all. This message means that the URL is OK and downloadable. If it wouldn't, we would get an error message, for example:

homerun.spec: I: checking-url http://download.kde.org/unstable/homerun/src/homerun-1.0.0.tar.bz2 (timeout 10 seconds)
homerun.spec: W: invalid-url Source0: http://download.kde.org/unstable/homerun/src/homerun-1.0.0.tar.bz2 HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.


Regarding the VCS revision in the tarball name, I had a look at the older tarballs. Seems to be it is usual for the upstream developer to do so. Well, it would be better to avoid confusion by extracting the tarball to a folder with the same name, but we have this problem in a lot of other stuff, so we can go ahead with the current situation.

Stay tuned for the final review.

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5446970

$ rpmlint -i -v *
python-tvrage.noarch: I: checking
python-tvrage.noarch: W: spelling-error %description -l en_US com's -> con's, om's, come's
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.noarch: W: spelling-error %description -l en_US api -> pi, ape, apt
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.noarch: I: checking-url https://pypi.python.org/pypi/python-tvrage (timeout 10 seconds)
python-tvrage.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tvrage/exceptions.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-tvrage.src: I: checking
python-tvrage.src: W: spelling-error %description -l en_US com's -> con's, om's, come's
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.src: W: spelling-error %description -l en_US api -> pi, ape, apt
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.src: I: checking-url https://pypi.python.org/pypi/python-tvrage (timeout 10 seconds)
python-tvrage.src: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds)
python-tvrage.spec: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 4 warnings.


The file /usr/lib/python2.7/site-packages/tvrage/exceptions.py is in a location where it is unneeded to be executable. That's why it needs to be patched to get rid of the shebang. The spelling errors are ignorable.

Fixed.

NEW Spec URL: http://cicku.me/python-tvrage.spec
NEW SRPM URL: http://cicku.me/python-tvrage-0.4.1-3.fc20.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5453845

$ rpmlint -i -v *
python-tvrage.noarch: I: checking
python-tvrage.noarch: W: spelling-error %description -l en_US com's -> con's, om's, come's
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.noarch: W: spelling-error %description -l en_US api -> pi, ape, apt
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.noarch: I: checking-url https://pypi.python.org/pypi/python-tvrage (timeout 10 seconds)
python-tvrage.src: I: checking
python-tvrage.src: W: spelling-error %description -l en_US com's -> con's, om's, come's
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.src: W: spelling-error %description -l en_US api -> pi, ape, apt
The value of this tag appears to be misspelled. Please double-check.

python-tvrage.src: I: checking-url https://pypi.python.org/pypi/python-tvrage (timeout 10 seconds)
python-tvrage.src: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds)
python-tvrage.spec: I: checking-url https://pypi.python.org/packages/source/p/python-tvrage/python-tvrage-0.4.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Nothing of interest anymore.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
    BSD
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    sha256sum *
    f8a530376c5cf1bc573d1945a8504c3394b228c731a3eff5100c705997a72063  python-tvrage-0.4.1.tar.gz
    f8a530376c5cf1bc573d1945a8504c3394b228c731a3eff5100c705997a72063  python-tvrage-0.4.1.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. 
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.


----------------

PACKAGE APPROVED

----------------

New Package SCM Request
=======================
Package Name: python-tvrage
Short Description: Python client for the tvrage.com XML API
Owners: cicku
Branches: f18 f19
InitialCC:

Git done (by process-git-requests).

python-tvrage-0.4.1-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-tvrage-0.4.1-3.fc19

python-tvrage-0.4.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-tvrage-0.4.1-3.fc18

python-tvrage-0.4.1-3.fc19 has been pushed to the Fedora 19 testing repository.

python-tvrage-0.4.1-3.fc19 has been pushed to the Fedora 19 stable repository.

python-tvrage-0.4.1-3.fc18 has been pushed to the Fedora 18 stable repository.