Bug 967705

Summary: [virt-sandbox-service] execute command with unsupported URI error msg is not right
Product: Red Hat Enterprise Linux 7 Reporter: Wayne Sun <gsun>
Component: libvirt-sandboxAssignee: Daniel Berrangé <berrange>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: ajia, dyuan, mzhan, weizhan, zpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-sandbox-0.2.1-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-13 12:20:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Wayne Sun 2013-05-28 05:47:05 UTC 
Description of problem:
Error msg output format is not right with execute on unsupported URI

# virt-sandbox-service -c qemu:///system execute apache10 /bin/sh
/usr/bin/virt-sandbox-service: C
/usr/bin/virt-sandbox-service: a
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: o
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: l
/usr/bin/virt-sandbox-service: y
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: e
/usr/bin/virt-sandbox-service: x
/usr/bin/virt-sandbox-service: e
/usr/bin/virt-sandbox-service: c
/usr/bin/virt-sandbox-service: u
/usr/bin/virt-sandbox-service: t
/usr/bin/virt-sandbox-service: e
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: c
/usr/bin/virt-sandbox-service: o
/usr/bin/virt-sandbox-service: m
/usr/bin/virt-sandbox-service: m
/usr/bin/virt-sandbox-service: a
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: d
/usr/bin/virt-sandbox-service: s
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: i
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: s
/usr/bin/virt-sandbox-service: i
/usr/bin/virt-sandbox-service: d
/usr/bin/virt-sandbox-service: e
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: o
/usr/bin/virt-sandbox-service: f
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: l
/usr/bin/virt-sandbox-service: i
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: u
/usr/bin/virt-sandbox-service: x
/usr/bin/virt-sandbox-service:  
/usr/bin/virt-sandbox-service: c
/usr/bin/virt-sandbox-service: o
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: t
/usr/bin/virt-sandbox-service: a
/usr/bin/virt-sandbox-service: i
/usr/bin/virt-sandbox-service: n
/usr/bin/virt-sandbox-service: e
/usr/bin/virt-sandbox-service: r
/usr/bin/virt-sandbox-service: s
/usr/bin/virt-sandbox-service: .

Version-Release number of selected component (if applicable):
libvirt-sandbox-0.2.0-1.el7.x86_64

How reproducible:
always

Steps to Reproduce:
1. as description
2.
3.

Actual results:
output is not right

Expected results:
# virt-sandbox-service -c qemu:///system execute apache10 /bin/sh
/usr/bin/virt-sandbox-service: Can only execute commands inside of linux containers.


Additional info:
This is a nit in commit 76241ce
Comment 2 Wayne Sun 2013-05-28 06:07:32 UTC 
Patch on upstream:

https://www.redhat.com/archives/libvir-list/2013-May/msg01876.html
Comment 3 Daniel Berrangé 2013-07-09 10:25:40 UTC 
commit aa8319e3a74c9ba06dc063081b6ffd578876e8ae
Author: Wayne Sun <gsun>
Date:   Tue Jul 9 11:23:34 2013 +0100

    Fix formatting in virt-sandbox-service when raising ValueError
    
    ValueError expects the argument to be a string list, not a
    plain string. Using a plain string results in bad formatting
    when printing the error later
    
    /usr/bin/virt-sandbox-service: C
    /usr/bin/virt-sandbox-service: a
    /usr/bin/virt-sandbox-service: n
    /usr/bin/virt-sandbox-service:
    /usr/bin/virt-sandbox-service: o
    /usr/bin/virt-sandbox-service: n
    /usr/bin/virt-sandbox-service: l
    /usr/bin/virt-sandbox-service: y
    /usr/bin/virt-sandbox-service:
    /usr/bin/virt-sandbox-service: e
    /usr/bin/virt-sandbox-service: x
    /usr/bin/virt-sandbox-service: e
    /usr/bin/virt-sandbox-service: c
...snip...
Comment 4 Wayne Sun 2013-07-10 10:36:45 UTC 
pkgs:
libvirt-sandbox-0.2.1-1.el7.x86_64
libvirt-gobject-0.1.6-1.el7.x86_64
libvirt-1.1.0-1.el7.x86_64
kernel-3.9.0-0.55.el7.x86_64
libvirt-gconfig-0.1.7-1.el7.x86_64

steps:
1. execute command on unsupported URI
# virt-sandbox-service -c qemu:///system execute aaa /bin/sh
/usr/bin/virt-sandbox-service: Can only execute commands inside of linux containers.

this is fixed now.
Comment 6 Ludek Smid 2014-06-13 12:20:54 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.