Bug 968605
Summary: | Review Request: nodejs-json2 - A normalizing wrapper around the json2 library and native JSON implementation | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jamie Nguyen <jamielinux> |
Component: | Package Review | Assignee: | Tom Hughes <tom> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, tom |
Target Milestone: | --- | Flags: | tom:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-02-23 13:47:35 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 968601, 968603, 1068937 | ||
Bug Blocks: |
Description
Jamie Nguyen
2013-05-29 22:49:05 UTC
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed [!]: Package contains no bundled libraries without FPC exception. lib/JSON2/static/json2.js bundled from http://www.JSON.org/json2.js [!]: Package complies to the Packaging Guidelines There is an mmd file in lib, duplicated in doc. lib/Task/JSON2/Bundle.js seems to have been built from the other files? [!]: License field in the package spec file matches the actual license. lib/JSON2/static/json2.js says PD but see above about bundling Haven't actually found any mention of GPLv3? [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: %check is present and all tests pass. Haven't managed to get them to run yet... ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [!]: Package complies to the Packaging Guidelines [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/tom/968605-nodejs-json2/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 5 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-json2-0.4.0-1.fc20.noarch.rpm nodejs-json2.noarch: W: only-non-binary-in-usr-lib nodejs-json2.noarch: W: dangling-symlink /usr/lib/node_modules/json2/node_modules/joose /usr/lib/node_modules/joose nodejs-json2.noarch: W: dangling-symlink /usr/lib/node_modules/json2/node_modules/joosex-namespace-depended /usr/lib/node_modules/joosex-namespace-depended 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-json2 nodejs-json2.noarch: W: only-non-binary-in-usr-lib nodejs-json2.noarch: W: dangling-symlink /usr/lib/node_modules/json2/node_modules/joose /usr/lib/node_modules/joose nodejs-json2.noarch: W: dangling-symlink /usr/lib/node_modules/json2/node_modules/joosex-namespace-depended /usr/lib/node_modules/joosex-namespace-depended 1 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- nodejs-json2 (rpmlib, GLIBC filtered): nodejs(engine) npm(joose) npm(joosex-namespace-depended) Provides -------- nodejs-json2: nodejs-json2 npm(json2) Source checksums ---------------- http://registry.npmjs.org/json2/-/json2-0.4.0.tgz : CHECKSUM(SHA256) this package : 2651a17812df89197071adfc718c06276db4503bb261997ad161fb7a5b83a7cd CHECKSUM(SHA256) upstream package : 2651a17812df89197071adfc718c06276db4503bb261997ad161fb7a5b83a7cd Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: compton-rawhide-x86_64 Command line :/usr/bin/fedora-review -m compton-rawhide-x86_64 -b 968605 Turns out nodeunit doesn't need this package. Bundle.js contains the whole of json2.js as well as an additional class appended to the file. There doesn't appear to be a good/efficient way to unbundle json2.js from Bundle.js so I'm not interested in packaging this anymore. Thanks for the review, but sorry for wasting your time Tom! |