Bug 969114
Summary: | Refactor unnecessary while loop in JndiAction class | ||
---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Tomas Dosek <tdosek> |
Component: | ovirt-engine | Assignee: | Martin Perina <mperina> |
Status: | CLOSED UPSTREAM | QA Contact: | movciari |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 3.3.0 | CC: | acathrow, bazulay, iheim, jkt, juan.hernandez, lpeer, mperina, pstehlik, Rhev-m-bugs, yeylon, yzaslavs |
Target Milestone: | --- | Keywords: | CodeChange, Triaged |
Target Release: | 3.3.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | infra | ||
Fixed In Version: | is8 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 968958 | Environment: | |
Last Closed: | 2013-08-12 07:00:44 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 968958 | ||
Bug Blocks: |
Description
Tomas Dosek
2013-05-30 16:50:22 UTC
JndiAction class is used only when adding, editing or validating domain from engine-manage-domains tool. I verified the change by adding and validating domain using engine-manage-domains for ActiveDirectory, IPA and OpenLDAP providers: $ ./bin/engine-manage-domains -action=add -domain=ad2.rhev.lab.eng.brq.redhat.com -user=vdcadmin -interactive -addPermissions -provider=ActiveDirectory Enter password: Successfully added domain ad2.rhev.lab.eng.brq.redhat.com. oVirt Engine restart is required in order for the changes to take place (service ovirt-engine restart). Manage Domains completed successfully $ ./bin/engine-manage-domains -action=validate Domain ad2.rhev.lab.eng.brq.redhat.com is valid. The configured user for domain ad2.rhev.lab.eng.brq.redhat.com is vdcadmin.LAB.ENG.BRQ.REDHAT.COM Manage Domains completed successfully $ ./bin/engine-manage-domains -action=add -domain=brq-ipa.rhev.lab.eng.brq.redhat.com -user=vdcadmin -interactive -addPermissions -provider=IPA Enter password: Successfully added domain brq-ipa.rhev.lab.eng.brq.redhat.com. oVirt Engine restart is required in order for the changes to take place (service ovirt-engine restart). Manage Domains completed successfully $ ./bin/engine-manage-domains -action=validate Domain brq-ipa.rhev.lab.eng.brq.redhat.com is valid. The configured user for domain brq-ipa.rhev.lab.eng.brq.redhat.com is vdcadmin.LAB.ENG.BRQ.REDHAT.COM Manage Domains completed successfully $./bin/engine-manage-domains -action=add -domain=brq-openldap.rhev.lab.eng.brq.redhat.com -user=vdcadmin -interactive -addPermissions -provider=OpenLDAP Enter password: Successfully added domain brq-openldap.rhev.lab.eng.brq.redhat.com. oVirt Engine restart is required in order for the changes to take place (service ovirt-engine restart). Manage Domains completed successfully $ ./bin/engine-manage-domains -action=validate Domain brq-openldap.rhev.lab.eng.brq.redhat.com is valid. The configured user for domain brq-openldap.rhev.lab.eng.brq.redhat.com is vdcadmin.LAB.ENG.BRQ.REDHAT.COM Manage Domains completed successfully |