Bug 969235

Summary:	Add version check tests for server utilities
Product:	[Retired] Beaker	Reporter:	Nick Coghlan <ncoghlan>
Component:	scheduler	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	develop	CC:	dcallagh, dowang, ebaak, jingwang, qwan, rjoost, tools-bugs
Target Milestone:	24.0	Keywords:	FutureFeature, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ImplementationQuality
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-02-21 18:50:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nick Coghlan 2013-05-31 01:49:58 UTC

Several of the server command line tools report a hardcoded version of "0.1". Some of these tools can also be broken without causing an obvious failure in the unittest suite.

A sanity check test that ensures the output of "<command> --version" matches the expected Beaker for version for each of these scripts would ensure that:

1. At least import failures resulting from changes in other parts of the code will be detected by the test suite, even if full operation of the tool is not yet covered.

2. The tools report the correct version.

Comment 1 wangjing 2013-06-21 02:51:52 UTC

(In reply to Nick Coghlan from comment #0)
> 
> A sanity check test that ensures the output of "<command> --version" matches
> the expected Beaker for version for each of these scripts would ensure that:
> 

hi, what is the specific command for version check tests? thanks.

Comment 2 Nick Coghlan 2013-06-21 02:59:20 UTC

Documenting the server utilities is covered by bug 970403

The approximate list is given by the "console_scripts" entry in the server setup.py: http://git.beaker-project.org/cgit/beaker/tree/Server/setup.py.in?h=develop#n203

Comment 4 Dan Callaghan 2016-10-25 02:13:14 UTC

http://gerrit.beaker-project.org/5353

Comment 5 Dan Callaghan 2016-10-25 02:14:39 UTC

This picked up a few other pre-existing problems with stderr spew, so it was  definitely worthwhile.

http://gerrit.beaker-project.org/5354 beaker-repo-update: don't spew pointless warnings about RHEL repos
http://gerrit.beaker-project.org/5355 beaker-create-kickstart: fix unicode warnings
http://gerrit.beaker-project.org/5356 tests: run server commands in subprocesses wherever possible

Comment 6 Dan Callaghan 2016-11-07 06:55:57 UTC

This bug fix is included in beaker-server-24.0-0.git.194.c515848 which is currently available for download here:

https://beaker-project.org/nightlies/develop/

Comment 8 Dan Callaghan 2017-02-21 18:50:40 UTC

Beaker 24.0 has been released.