Bug 969387 (freetiger)
| Summary: | Review Request: freetiger - Free implementation of the tiger hash algorithm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Björn 'besser82' Esser <besser82> | ||||
| Component: | Package Review | Assignee: | Will Benton <willb> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fdc, i, notting, willb | ||||
| Target Milestone: | --- | Flags: | willb:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | freetiger-5-2.el5 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-08-30 23:01:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 966324 | ||||||
| Attachments: |
|
||||||
|
Description
Björn 'besser82' Esser
2013-05-31 10:46:55 UTC
Thanks for packaging it~ Can you tell me the source1's purpose? Since Source0 only ships some code without any buildsystem (autotools, cmake, etc.), I've added (Source1) some simple CMake buildscript around to have Source0 build a shlib. > %package devel > Requires: cmake That's an unusually strict dependency for a -devel package. Note that it also includes a pkgconfig file, so clearly it does not _need_ cmake. If the dep is just for directory ownership, you're free to own the cmake dir: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Spec URL: http://besser82.fedorapeople.org/review/freetiger/freetiger.spec SRPM URL: http://besser82.fedorapeople.org/review/freetiger/freetiger-5-2.fc19.src.rpm %changelog * Fri May 31 2013 Björn Esser <bjoern.esser> - 5-2 - devel shouldn't require cmake, owning %%{_libdir}/cmake is enough. * Fri May 31 2013 Björn Esser <bjoern.esser> - 5-1 - Initial rpm release koji-build logs: rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463919 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463922 F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463925 F17: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463928 el6: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463932 el5: http://koji.fedoraproject.org/koji/taskinfo?taskID=5463939 No progress from assignee since 8 weeks... Resetting to NEW Created attachment 791138 [details]
review text
I've reviewed the package and found only a minor change necessary (to the license field). Please fix this when importing. Thanks!
Thanks for the review, Will! :) ##### New Package SCM Request ======================= Package Name: freetiger Short Description: Free implementation of the tiger hash algorithm Owners: besser82 Branches: el5 el6 f18 f19 f20 InitialCC: Git done (by process-git-requests). freetiger-5-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/freetiger-5-2.el5 freetiger-5-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/freetiger-5-2.el6 freetiger-5-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/freetiger-5-2.fc18 freetiger-5-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/freetiger-5-2.fc19 freetiger-5-2.el5 has been pushed to the Fedora EPEL 5 testing repository. freetiger-5-2.fc18 has been pushed to the Fedora 18 stable repository. freetiger-5-2.fc19 has been pushed to the Fedora 19 stable repository. freetiger-5-2.el6 has been pushed to the Fedora EPEL 6 stable repository. freetiger-5-2.el5 has been pushed to the Fedora EPEL 5 stable repository. |