Bug 969631
| Summary: | Review Request: dlib - A general purpose cross-platform C++ library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> | ||||
| Component: | Package Review | Assignee: | Björn 'besser82' Esser <besser82> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | besser82, i, ignatenko, package-review | ||||
| Target Milestone: | --- | Flags: | besser82:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | NotReady | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-12-15 21:06:48 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Christopher Meng
2013-06-01 05:58:36 UTC
Hi Christopher! -BuildRequires: cmake libjpeg-devel libpng-devel +BuildRequires: atlas-devel cmake fftw-devel +BuildRequires: libjpeg-devel libpng-devel sqlite-devel To get out all dlib offers... There should be a usable shlib, but dlib only builds a static one (which also isn't pkged). Ask upstream to setup a suitable top-level CMakeLists.txt, which builds all stuff in a row and offers options for building a shlib and `make install` to proper locations. If help is needed with CMake, feel free to ask me... These are the first things needed to be fixed/worked out, when done I'll start next review-run. Cheers, Björn. BTW. -debuginfo builds to an empty-pkg, too. > Summary: A general purpose cross-platform C++ library In Anaconda and package tools, which display these summaries, it looks better (and more concise) when omitting these leading articles. > License: Boost and Public Domain I'm not sure about the "and" here. Please add a comment to the spec file, which explains this licensing scenario. $ grep -i "public domain" * -R|egrep -v '(html|examples|tools)' dlib/general_hash/murmur_hash3.h: // in the public domain. The author hereby disclaims copyright to this source code. The murmur_hash3.h file applies the Boost license and copyright in its preamble and mentions modifications by the library author. As such it cannot be assumed that the entire file remains in the public domain. Therefore the lib is "License: Boost" only. Several examples contain a "public domain" header and refer to the separate LICENSE_FOR_EXAMPLE_PROGRAMS.txt file. As the entire "examples" tree is packaged in the -doc file, the -doc file could apply a different "License" tag than the base package. The "tools/mltool" program is in the "public domain", but not built or packaged. * The test build.log warns about missing build requirements. X11, BLAS. What's up there? * Is the included regression test suite suitable for the %check section? > %install > > pushd %{name} > rm -rf CMakeFiles/ cmake* Makefile > popd That's a perfect opportunity for a comment that explains why this is done. ;-) > %package doc > Summary: Documentation for the %{name} > Requires: %{name}%{?_isa} = %{version}-%{release} Independent documentation -doc packages typically don't require the base package. It should be possible to install documentation without having to install a program and all its dependencies. Created attachment 915791 [details]
Comment
(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).
This package is more than a crap. I will fix it later, but probably very hard. Lets use new review. *** This bug has been marked as a duplicate of bug 1288643 *** |