Bug 969930

Summary:	The PHPRC environment variable in rockmongo is not created as raw value format
Product:	OpenShift Online	Reporter:	Jianwei Hou <jhou>
Component:	Containers	Assignee:	Jhon Honce <jhonce>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	high
Version:	2.x	CC:	pmorie
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-11 04:15:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jianwei Hou 2013-06-03 05:52:47 UTC

Description of problem:
Create an application with mongodb-2.2 and rockmongo-1.1 added. The content of "PHPRC" created under ~/rockmongo/env is still using the "export key=value" format. Maybe it should only store the raw value to be consistent with the other environment variables.

Version-Release number of selected component (if applicable):
On STG(devenv-stage_356), devenv-stage_356

How reproducible:
Always

Steps to Reproduce:
1. Create an app with mongodb-2.2 and rockmongo-1.1
rhc app create php1 php-5.3 mongodb-2.2 rockmongo-1.1
2. SSH into app
rhc app-ssh php1
3. Check the value for PHPRC in rhcsh

Actual results:
The PHPRC still exports the environment variable the old fashioned way. However, the value can be correctly sourced.
[php1-jhou6.dev.rhcloud.com env]\> pwd
/var/lib/openshift/716232416361372832497664/rockmongo/env
[php1-jhou6.dev.rhcloud.com env]\> cat PHPRC 
export PHPRC="/var/lib/openshift/716232416361372832497664/rockmongo/etc/conf/php.ini"
[php1-jhou6.dev.rhcloud.com env]\> echo $PHPRC
/var/lib/openshift/716232416361372832497664/php//configuration/etc/php.ini

Expected results:
PHPRC should store a raw value
eg: 
[php1-jhou6.dev.rhcloud.com env]\> cat PHPRC 
/var/lib/openshift/716232416361372832497664/rockmongo/etc/conf/php.ini

Additional info:

Comment 1 Paul Morie 2013-06-03 14:25:32 UTC

PR submitted to master

Comment 2 openshift-github-bot 2013-06-03 17:59:58 UTC

Commit pushed to master at https://github.com/openshift/li

https://github.com/openshift/li/commit/202c6111c1b8f5e672619c7840080cbd951038a8
Fix bug 969930

Comment 3 Paul Morie 2013-06-03 18:05:48 UTC

PRs merged to master and stage.

Comment 4 Jianwei Hou 2013-06-04 01:50:54 UTC

Verified on STG
Add rockmongo cartridge to an application, check the value of PHPRC, now it is raw value format

[as1-sprint25.stg.rhcloud.com env]\> echo $PHPRC
/var/lib/openshift/5153f657dbd93c5bcc0000c7/rockmongo/etc/conf/php.ini
[as1-sprint25.stg.rhcloud.com env]\> cat PHPRC 
/var/lib/openshift/5153f657dbd93c5bcc0000c7/rockmongo/etc/conf/php.ini