Bug 970282

Summary: [PATCH] pacrunner_mozjs: Also support mozjs-17.0
Product: [Fedora] Fedora Reporter: Colin Walters <walters>
Component: libproxyAssignee: Christopher Meng <i>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: dwmw2, nathaniel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-29 11:59:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
0001-pacrunner_mozjs-Also-support-mozjs-17.0.patch none

Description Colin Walters 2013-06-03 21:24:10 UTC
Created attachment 756539 [details]
0001-pacrunner_mozjs-Also-support-mozjs-17.0.patch

See http://lists.fedoraproject.org/pipermail/devel/2013-April/181131.html

Comment 1 Colin Walters 2013-06-03 21:25:53 UTC
NOTE: Compile tested only.  

Here's the obvious spec file diff:

diff --git a/libproxy.spec b/libproxy.spec
index e72a400..74a3561 100644
--- a/libproxy.spec
+++ b/libproxy.spec
@@ -12,7 +12,7 @@
 
 Name:           libproxy
 Version:        0.4.11
-Release:        3%{?svn}%{?dist}
+Release:        4%{?svn}%{?dist}
 Summary:        A library handling all the details of proxy configuration
 
 Group:          System Environment/Libraries
@@ -21,6 +21,7 @@ URL:            http://code.google.com/p/libproxy/
 
 Source0:        http://libproxy.googlecode.com/files/libproxy-%{version}%{?svn}.tar.gz
 Patch0:         libproxy-0.4.10-mozjs.patch
+Patch1:         0001-pacrunner_mozjs-Also-support-mozjs-17.0.patch
 
 BuildRequires:  python-devel
 BuildRequires:  libmodman-devel >= 2.0.1
@@ -32,7 +33,7 @@ BuildRequires:  GConf2-devel
 BuildRequires:  libXmu-devel
 }
 # mozjs
-%{?_with_mozjs:BuildRequires: js-devel}
+%{?_with_mozjs:BuildRequires: mozjs17-devel}
 # NetworkManager
 %{?_with_networkmanager:
 BuildRequires:  NetworkManager-devel
@@ -171,6 +172,7 @@ developing applications that use %{name}.
 %prep
 %setup -q
 %patch0 -p1 -b .orig
+%patch1 -p1 -b .orig
 
 %build
 %{cmake} \

Comment 2 Nicolas Chauvet (kwizart) 2013-06-03 21:30:21 UTC
OK, please go ahead with f19/devel

Comment 3 Nicolas Chauvet (kwizart) 2013-06-03 21:31:52 UTC
BTW, there is still an issue if the libproxy-mozjs doesn't end in the install media. So it may be required by each Desktop Spin group.

Comment 4 Colin Walters 2013-06-04 13:48:16 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #2)
> OK, please go ahead with f19/devel

Do you have a proxy configuration with PAC?  Can you test this before I upload it?

Comment 5 Fedora Admin XMLRPC Client 2013-06-05 03:12:54 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 6 David Woodhouse 2013-06-07 11:52:17 UTC
(In reply to Colin Walters from comment #1)

> -%{?_with_mozjs:BuildRequires: js-devel}
> +%{?_with_mozjs:BuildRequires: mozjs17-devel}

That would be better expressed as 
 BuildRequires: pkgconfig(mozjs-17.0)

It's easy enough to generate a PAC file to point to your local proxy. With squid running (a fairly basic install) on a local machine on my home network, I can throw together a PAC file in three lines:

function FindProxyForURL(url, host)
{
       return "PROXY twosheds.infradead.org:3128";
}

Comment 7 Colin Walters 2013-06-07 18:25:24 UTC
(In reply to David Woodhouse from comment #6)
> (In reply to Colin Walters from comment #1)
> 
> > -%{?_with_mozjs:BuildRequires: js-devel}
> > +%{?_with_mozjs:BuildRequires: mozjs17-devel}
> 
> That would be better expressed as 
>  BuildRequires: pkgconfig(mozjs-17.0)

True, but the rest of the BRs are not virtual.  I'd rather do this sort of conversion en-masse later across many spec files.

> It's easy enough to generate a PAC file to point to your local proxy. With
> squid running (a fairly basic install) on a local machine on my home
> network, I can throw together a PAC file in three lines:
> 
> function FindProxyForURL(url, host)
> {
>        return "PROXY twosheds.infradead.org:3128";
> }

Will try, thanks.

Comment 8 Fedora End Of Life 2013-09-16 14:04:47 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 9 Fedora End Of Life 2015-05-29 09:05:49 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 10 Fedora End Of Life 2015-06-29 11:59:20 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.