Bug 970405

Summary:	Review Request: mingw-speex - A voice compression format (codec)
Product:	[Fedora] Fedora	Reporter:	Steve <ulatekh>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amigadave, mindruv, package-review, ulatekh, valtri
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-06 15:26:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	970408

Description Steve 2013-06-04 00:45:40 UTC

Spec URL: https://www.box.com/s/cgjsx9uum2eilssv0fm8
SRPM URL: https://www.box.com/s/vjfmdof5tdbbe66lb3xq
Description: Speex is a patent-free compression format designed especially for speech. It is specialized for voice communications at low bit-rates in the 2-45 kbps range. Possible applications include Voice over IP  (VoIP), Internet audio streaming, audio books, and archiving of speech data (e.g. voice mail).
This is the MinGW version of a package that Fedora already has in its repository.
Fedora Account System Username: ulatekh

Comment 1 Veaceslav Mindru 2013-07-30 08:01:46 UTC

Hello Steve,

same sorry here.  Remove rm buildroot in %install section and remove %clean section. 

>%install
>rm -rf $RPM_BUILD_ROOT


>%clean
>rm -rf $RPM_BUILD_ROOT



http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

Comment 2 František Dvořák 2014-01-26 20:24:11 UTC

Steve, do you plan to continue on the work on mingw-speex? It looks like there is no response more than one month and this review can be closed as dead review (http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews).


Found issues: (no problem is critical, but 1) and 4) is checked by rpmlint)

1) as mentioned by Veaceslav: Group, %clean, %defattr and 'rm -f' in %install are not needed

2) manual.pdf and manual pages are not needed (already in the native package), NEWS and TODO could be removed too

3) dependencies:
 - BuildRequire: is MinGW gcc-c++ needed? binutils can be removed ("inherited" by gcc)
 - Requires: pkgconfig not needed - it is used only on base package, on real mingw32/64 subpackages there should be mingw32/64 version of pkgconfig anyway and it is autogenerated

4) cosmetic: mixed spaces and tabs

5) descriptions could be reformatted/unified

6) cosmetic: combining %exclude (for .la) and 'rm -f' (for manual.pdf)

Comment 3 František Dvořák 2014-02-06 15:26:49 UTC


*** This bug has been marked as a duplicate of bug 1062291 ***