Bug 970924
| Summary: | rpm-goto-add-change-log-entry is not working as expected | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Synacek <jsynacek> | ||||
| Component: | emacs | Assignee: | Petr Hracek <phracek> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 18 | CC: | bugs.michael, jonathan.underwood, phracek | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | emacs-24.2-20.fc18 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-08-02 03:27:02 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Hi Jan,
thanks for the bug,
I have improve them so that it looks now:
diff --git a/site-lisp/rpm-spec-mode.el b/site-lisp/rpm-spec-mode.el
index 63c37fa..88a7247 100644
--- a/site-lisp/rpm-spec-mode.el
+++ b/site-lisp/rpm-spec-mode.el
@@ -739,12 +739,16 @@ If `rpm-change-log-uses-utc' is nil, \"today\" means the local time zone."
(interactive "sChange log entry: ")
(save-excursion
(rpm-goto-add-change-log-header)
+ (while (looking-at "^-")
+ (forward line))
(insert "- " change-log-entry "\n")))
(defun rpm-goto-add-change-log-entry ()
"Goto change log and add an header for today (if needed)."
(interactive)
(rpm-goto-add-change-log-header)
+ (while (looking-at "^-")
+ (forward line))
(insert "- \n")
(end-of-line '0))
Thanks. I guess the whitespaces chars got eaten somehow. This bug has been fixed in f18. scm-commit (https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20130610/1037403.html) -> MODIFIED emacs-24.2-19.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/emacs-24.2-19.fc18 Package emacs-24.2-19.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing emacs-24.2-19.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-10635/emacs-24.2-19.fc18 then log in and leave karma (feedback). emacs-24.2-19.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. I've repaired the patch to call "forward-line" instead of "forward line". http://koji.fedoraproject.org/koji/taskinfo?taskID=5606967 Update for F18 coming shortly... emacs-24.2-20.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/emacs-24.2-20.fc18 Package emacs-24.2-20.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing emacs-24.2-20.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-13024/emacs-24.2-20.fc18 then log in and leave karma (feedback). emacs-24.2-20.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 757078 [details] Patch Description of problem: Supposed I have a %changelog part of my spec file that's looking like this: %changelog * Wed Jun 5 2013 Jan Synáček <jsynacek> - 1:24.3-9 - change 1 - change 2 Executing rpm-goto-add-change-log-entry results in the next entry being positioned between those two entries (always after the first one). Version-Release number of selected component (if applicable): emacs-24.2-18.fc18.x86_64 How reproducible: Always. Actual results: Next entry is always inserted after the first one. Expected results: Next entry is always inserted as the last one.